New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CD step that checks for .meta files should (also?) be done in CI steps #7

Open

bddckr opened this issue Jan 21, 2019 · 1 comment

Labels

bddckr commented Jan 21, 2019

Otherwise CI says "good to merge" and then the merge fails in the CD.

bddckr added bug w_ready labels

Author

bddckr commented Jan 29, 2019

This may only be happening in PR validation builds as we're currently skipping the whole semantic-release usage when it's a PR IIRC.

So ensure both: CI should do the .meta file check, but CI should also run those when doing a PR validation build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment