Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic of Call/Calling pages out of the page #58

Open
jordibc opened this issue Aug 25, 2017 · 3 comments
Open

Move logic of Call/Calling pages out of the page #58

jordibc opened this issue Aug 25, 2017 · 3 comments
Assignees

Comments

@jordibc
Copy link
Contributor

jordibc commented Aug 25, 2017

Murhaf, if you could remind me where we were putting the logic and an example of a module that is already using it?

@MurhafSousli
Copy link
Contributor

@jordibc I suggest the about page example
But about page doesn't use a service, so you just need to add a service for calling page I guess

src
  calling
       calling.module.ts
       calling.ts
       calling.html
       calling.scss
       calling.service.ts

@jordibc
Copy link
Contributor Author

jordibc commented Aug 27, 2017

Thanks @MurhafSousli !

@MurhafSousli
Copy link
Contributor

In case you chose ModalController, there is no need to make calling.ts as a lazy page anymore, it can be used as a normal component without calling.module.ts

src
  call
       calling-dialog
              calling.ts
              calling.html
              calling.scss

       call.ts
       call.html
       call.scss
       call.service.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants