Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQ: Get Contact Emails for Follow-Up issue #27

Merged
merged 9 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove quality analysis in datastore
  • Loading branch information
eperedo committed Mar 15, 2024
commit 818d811acc7caa7e4891c5add6588c44059e1105
4 changes: 2 additions & 2 deletions src/data/repositories/IssueD2Repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,8 @@ export class IssueD2Repository implements IssueRepository {
);

const statusFilter = this.buildFilterMultipleValue(
filter.actions,
this.metadata.dataElements.action.id
filter.status,
this.metadata.dataElements.status.id
);

const actionsFilter = this.buildFilterMultipleValue(
Expand Down
28 changes: 19 additions & 9 deletions src/data/repositories/QualityAnalysisD2Repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,28 @@ export class QualityAnalysisD2Repository implements QualityAnalysisRepository {
});
}

remove(id: Id[]): FutureData<void> {
remove(id: Id): FutureData<void> {
return apiToFuture(
this.api.tracker.post(
this.api.tracker.postAsync(
{ importStrategy: "DELETE" },
{ trackedEntities: id.map(id => ({ trackedEntity: id })) }
{ trackedEntities: [{ trackedEntity: id }] }
)
).flatMap(d2Response => {
if (d2Response.status === "ERROR") {
return Future.error(new Error(d2Response.message));
} else {
return Future.success(undefined);
}
).flatMap(d2JobResponse => {
return apiToFuture(
// this rule is being applied outside the context of testing-library
// more info here: https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/await-async-utils.md
// eslint-disable-next-line testing-library/await-async-utils
this.api.system.waitFor("TRACKER_IMPORT_JOB", d2JobResponse.response.id)
).flatMap(d2Response => {
if (d2Response?.status === "ERROR") {
return Future.error(new Error(d2Response.message));
} else {
const dataStore = this.api.dataStore(DATA_QUALITY_NAMESPACE);
return apiToFuture(dataStore.delete(id)).flatMap(() => {
return Future.success(undefined);
});
}
});
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/domain/repositories/QualityAnalysisRepository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export interface QualityAnalysisRepository {
get(options: QualityAnalysisOptions): FutureData<QualityAnalysisPaginated>;
getById(id: Id): FutureData<QualityAnalysis>;
save(qualityAnalysis: QualityAnalysis[]): FutureData<void>;
remove(id: Id[]): FutureData<void>;
remove(id: Id): FutureData<void>;
}

export type Pagination = {
Expand Down
10 changes: 9 additions & 1 deletion src/domain/usecases/RemoveQualityUseCase.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
import { FutureData } from "$/data/api-futures";
import { Id } from "$/domain/entities/Ref";
import { QualityAnalysisRepository } from "$/domain/repositories/QualityAnalysisRepository";
import { Future } from "$/domain/entities/generic/Future";

export class RemoveQualityUseCase {
constructor(private qualityAnalysisRepository: QualityAnalysisRepository) {}

execute(qualityAnalysisIds: Id[]): FutureData<void> {
return this.qualityAnalysisRepository.remove(qualityAnalysisIds);
const concurrencyRequest = 5;
const $requests = Future.parallel(
qualityAnalysisIds.map(issue => this.qualityAnalysisRepository.remove(issue)),
{ concurrency: concurrencyRequest }
);
return $requests.flatMap(() => {
return Future.success(undefined);
});
}
}