fixed period range for datavalues endpoint

src/domain/usecases/RunPractitionersValidationUseCase.ts

@@ -16,10 +16,12 @@ import { IssueRepository } from "$/domain/repositories/IssueRepository";
 import { UCIssue } from "./common/UCIssue";
 import { UCAnalysis } from "./common/UCAnalysis";
 import i18n from "$/utils/i18n";
+import { UCDataValue } from "$/domain/usecases/common/UCDataValue";
 
 export class RunPractitionersValidationUseCase {
     issueUseCase: UCIssue;
     analysysUseCase: UCAnalysis;
+    private dataValueUseCase: UCDataValue;
 
     constructor(
         private analysisRepository: QualityAnalysisRepository,
@@ -29,6 +31,7 @@ export class RunPractitionersValidationUseCase {
     ) {
         this.analysysUseCase = new UCAnalysis(this.analysisRepository);
         this.issueUseCase = new UCIssue(this.issueRepository);
+        this.dataValueUseCase = new UCDataValue(this.dataValueRepository);
     }
 
     execute(options: PractitionersValidationOptions): FutureData<QualityAnalysis> {
@@ -346,20 +349,11 @@ export class RunPractitionersValidationUseCase {
     }
 
     private getDataValues(qualityAnalysis: QualityAnalysis): FutureData<DataValue[]> {
-        const $requests = _(qualityAnalysis.countriesAnalysis)
-            .chunk(1)
-            .map(countryIds => {
-                return this.dataValueRepository.get({
-                    moduleIds: [qualityAnalysis.module.id],
-                    countriesIds: countryIds,
-                    period: _([qualityAnalysis.startDate, qualityAnalysis.endDate]).uniq().value(),
-                });
-            })
-            .value();
-
-        return Future.sequential($requests).flatMap(result => {
-            return Future.success(_(result).flatten().value());
-        });
+        return this.dataValueUseCase.get(
+            qualityAnalysis.countriesAnalysis,
+            [qualityAnalysis.module.id],
+            [qualityAnalysis.startDate, qualityAnalysis.endDate]
+        );
     }
 
     private getDataElementsByDisaggregationIds(

src/domain/usecases/common/UCDataValue.ts

@@ -10,13 +10,16 @@ export class UCDataValue {
     constructor(private dataValueRepository: DataValueRepository) {}
 
     get(countriesIds: Id[], moduleIds: Id[], periods: Period[]): FutureData<DataValue[]> {
+        const [startDate, endDate] = periods;
+        if (!startDate || !endDate) throw new Error("Invalid period");
+        const periodsToSearch = _.range(Number(startDate), Number(endDate) + 1);
         const $requests = _(countriesIds)
             .chunk(1)
             .map(countryIds => {
                 return this.dataValueRepository.get({
                     moduleIds: moduleIds,
                     countriesIds: countryIds,
-                    period: _(periods).uniq().value(),
+                    period: periodsToSearch.map(period => String(period)),
                 });
             })
             .value();