Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issues + i18n refactors #91

Merged
merged 11 commits into from
Aug 14, 2024
Merged

Security issues + i18n refactors #91

merged 11 commits into from
Aug 14, 2024

Conversation

tokland
Copy link
Contributor

@tokland tokland commented Jun 10, 2024

📌 References

  • Issue: Closes #?

📝 Implementation

📹 Screenshots/Screen capture

🔥 Notes to the tester

@adrianq adrianq requested a review from p3rcypj July 23, 2024 18:04
@tokland tokland self-assigned this Jul 25, 2024
@tokland tokland marked this pull request as ready for review July 25, 2024 11:14
@tokland
Copy link
Contributor Author

tokland commented Jul 25, 2024

@p3rcypj Can you please review that the branch is working for you? I've updated some packages to keep the security messages to a minimum.

I've also enabled linting messages in the "yarn start" console and hidden them in the browser. That's what we are used to in CRA projects and I think it's a sensible configuration.

@tokland
Copy link
Contributor Author

tokland commented Jul 25, 2024

Snyk current status:

$ snyk test > out; cat out | grep Upgrade; cat out | grep "introduced by" | sed "s/^.*introduced by //" | sort -u
[email protected] > [email protected] > [email protected] and 1 other path(s)
@dhis2/[email protected] > [email protected] and 2 other path(s)
@dhis2/[email protected] > [email protected] > [email protected] > [email protected] > [email protected]
@dhis2/[email protected] > [email protected] > [email protected] > [email protected] and 1 other path(s)

d2 and @dhis2/d2-i18n packages are already in the last version, we'd need upstream to update them.

Copy link
Contributor

@p3rcypj p3rcypj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working as a charm! 🌟

@tokland tokland changed the title Fix/security issues Security issues + i18n refactors Aug 1, 2024
@tokland
Copy link
Contributor Author

tokland commented Aug 1, 2024

  • Improve i18n typings + explicit namespace

@adrianq adrianq merged commit 33fc8b4 into master Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants