Apply rule only on updated field and delete default switch case not n…

…eeded
EyeSeeTea · Aug 20, 2024 · 3136ecc · 3136ecc
1 parent e05d8a2
commit 3136ecc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/webapp/pages/form-page/disease-outbreak-event/utils/applyRulesInFormState.ts b/src/webapp/pages/form-page/disease-outbreak-event/utils/applyRulesInFormState.ts
@@ -23,8 +23,6 @@ export function applyRulesInFormState(
                         toggleSectionVisibilityByFieldValue(section, updatedField.value, rule)
                     ),
                 };
-            default:
-                return formState;
         }
     }, currentFormState);
 

diff --git a/...ebapp/pages/form-page/disease-outbreak-event/utils/updateDiseaseOutbreakEventFormState.ts b/...ebapp/pages/form-page/disease-outbreak-event/utils/updateDiseaseOutbreakEventFormState.ts
@@ -19,9 +19,16 @@ export function updateDiseaseOutbreakEventFormState(
     currentUserUsername: string
 ): FormState {
     const updatedForm = updateFormStateAndApplySideEffects(prevFormState, updatedField);
-    const updatedFormWithRulesApplied = diseaseOutbreakEventWithOptions.rules.length
-        ? applyRulesInFormState(updatedForm, updatedField, diseaseOutbreakEventWithOptions.rules)
-        : updatedForm;
+
+    const updatedFormWithRulesApplied =
+        diseaseOutbreakEventWithOptions.rules.filter(rule => rule.fieldId === updatedField.id)
+            .length > 0
+            ? applyRulesInFormState(
+                  updatedForm,
+                  updatedField,
+                  diseaseOutbreakEventWithOptions.rules
+              )
+            : updatedForm;
 
     const fieldValidationErrors = validateDiseaseOutbreakEventFormState(
         updatedFormWithRulesApplied,