Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Multiple fixes #33

Merged
merged 9 commits into from
Nov 7, 2024
Merged

fix: Multiple fixes #33

merged 9 commits into from
Nov 7, 2024

Conversation

9sneha-n
Copy link
Contributor

@9sneha-n 9sneha-n commented Oct 31, 2024 •
edited
Loading

  • Issue: Closes #?

📝 Implementation

  • Feedback from the client : 717 response action 7 needs an NA checkbox, Remove the NA checkbox from response action 3
  • One of the cards - Response is missing in Event Tracker 717 indicators section.
  • Event Tracker 717 cards color Fix.
  • Do not show existing suspected disease and hazard type in Event tracker create form dropdown
  • refactor : useCallback, some renaming, some code rearranging for readability.
  • Add line space support in summaries.
  • Write permission check on create/edit forms.

📹 Screenshots/Screen capture

Screenshot 2024-10-31 at 10 35 16 PM Screenshot 2024-10-31 at 11 01 11 PM Screenshot 2024-10-31 at 11 05 55 PM Screenshot 2024-11-01 at 12 11 19 AM Screenshot 2024-11-01 at 12 11 27 AM ### 📌 References Screenshot 2024-11-01 at 12 30 11 AM Screenshot 2024-11-01 at 12 30 21 AM Screenshot 2024-11-02 at 11 57 27 AM Screenshot 2024-11-02 at 11 57 50 AM Screenshot 2024-11-02 at 11 58 02 AM Screenshot 2024-11-02 at 11 58 08 AM Screenshot 2024-11-02 at 11 58 13 AM

🔥 Notes to the tester

@9sneha-n 9sneha-n changed the title fix: response actions fix + event tracker 717 cards fix fix: Multiple fixes Nov 2, 2024
@9sneha-n 9sneha-n marked this pull request as ready for review November 3, 2024 17:36
anagperal
anagperal approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n !!

Base automatically changed from feature/cases-deaths-fix to development November 7, 2024 09:56
@bhavananarayanan bhavananarayanan merged commit a8e5fc8 into development Nov 7, 2024
1 check passed
@bhavananarayanan bhavananarayanan deleted the fix/oct-misc-bug-fixes branch November 7, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anagperal anagperal anagperal approved these changes

@bhavananarayanan bhavananarayanan Awaiting requested review from bhavananarayanan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9sneha-n @anagperal @bhavananarayanan