Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few little things! #37

Open
Oliversw opened this issue Jun 19, 2019 · 1 comment
Open

Few little things! #37

Oliversw opened this issue Jun 19, 2019 · 1 comment

Comments

@Oliversw
Copy link

  • Don't forget about adding little bits to your readme as you go. Otherwise it can be useful to make sure that you take notes as you go so that you can put them all together
  • Global styles: styled components has a helper function to create a global stylesheet if you're interested (https://www.styled-components.com/docs/api#createglobalstyle). Not a major thing, but might help keep your styles more consistent across your app. Here's an example from our current project: https://github.com/founders-programme-2/business-launchpad/blob/staging/client/src/styles/globalStyle.js
  • There's only a few days left - and that's totally fine! I would suggest getting together as a group and trying to decide on what your (achievable) priorities are before the handover. You can then create issues for each, and try to estimate times for each task - it's hard, and probably won't be accurate, but it's worth trying. I'd love to briefly hear about what you all decide to focus on.
  • Husky/Lint-staged look great! They're in the dependencies section, but looks like they might be better in the dev dependencies.
  • 'react-dnd-html5-backend' might not be a necessary module since according to the npm page: "** NOTE: React-Dnd has been restructured as a monorepo. This code has been merged into the the react-dnd main repository."
  • Naming styled-components
    • We just started using this convention for naming styled components and found that it helps a lot to keep things more consistent:
import Header from ‘Components/Header’;
import * as S from ‘./styles';
const Navigation = () => (
  <S.Navigation>
    <Header>{headerContent}</Header>
    <S.Content>{content}</S.Content>
  </S.Navigation>
);
  • We can write the style file like this:
import styled from 'styled-components';

export const Label = styled.label`
   //STYLES HERE//
`;

export const Input = styled.input`
   //STYLES HERE//
`;

For more: https://medium.com/inturn-eng/naming-styled-components-d7097950a245

@sylv1ah
Copy link
Collaborator

sylv1ah commented Jun 19, 2019

Thanks for these tips Oliver! Ur amazin ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants