You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We will be working off master for the first sprint, then will discuss on working of a staging branch for the second sprint
Branch names:
feature/name-of-feature
fix/issue# or fix/name-of-fix
Commits and commit messages:
To be written in present tense explaining what the commit does. Each commit should aim to only address one action.
Naming Structure:
Functions - camelCase, describe what it does
Classes - Block Element Modifier (BEM)
Tests - [filename].test.js
Routes - if more than one word, dash between words
Follow the checklist below.
Create the PR and assign the other pair (who haven't worked on the code) as reviewers.
Relate the issue number either in the commit message or pull request message.
Merging pull requests:
Check through the code carefully, comment on anything questionable by hovering over the line and clicking the blue plus that appears.
If changes need to be made, add the changes-needed label.
If everything is a-okay, merge the pull request and delete the branch.
Accessibility:
Avoid divs in favour of semantic elements (eg section, header, button) wherever possible.
All form elements should have labels.
Use Aria roles as a last resort.
Process Guide
Daily Schedule:
10am : Start
10:15 - 10:30 : Standup
10:30 - 11:45 : Build
11:45 - 12:00 : Break + Check ups
12:00 - 1:00 : Build
LUNCH
2:00 - 3:30 : Build + Swap pairs
3:30 - 3:45 : Break + Check up
3:45 - 5:00 : Build
5:00 - 5:15: Break (Or finish if theres a scheduled speaker)
5:15 - 6:00: Build
Branches:
We will be working off master for the first sprint, then will discuss on working of a staging branch for the second sprint
Branch names:
Commits and commit messages:
To be written in present tense explaining what the commit does. Each commit should aim to only address one action.
Naming Structure:
Functions - camelCase, describe what it does
Classes - Block Element Modifier (BEM)
Tests - [filename].test.js
Routes - if more than one word, dash between words
Asynchronicity:
Whenever possible, use promises over callbacks.
Styling:
For styling we will be using styled-components
https://www.styled-components.com/docs
component file name:
styled-components file name:
Opening pull requests:
Follow the checklist below.
Create the PR and assign the other pair (who haven't worked on the code) as reviewers.
Relate the issue number either in the commit message or pull request message.
Merging pull requests:
Check through the code carefully, comment on anything questionable by hovering over the line and clicking the blue plus that appears.
If changes need to be made, add the changes-needed label.
If everything is a-okay, merge the pull request and delete the branch.
Accessibility:
Avoid divs in favour of semantic elements (eg section, header, button) wherever possible.
All form elements should have labels.
Use Aria roles as a last resort.
(Process guide inspired by @jokosanyang ✨)
Style Guide
Figma
https://www.figma.com/file/IV6lJc5K9AlAhFYehxRk11c0/RE4.W?node-id=0%3A1
Colours
Typography
Typeface: Bangers
https://fonts.google.com/specimen/Bangers
Use em/rem instead of px!
Space and sizing
Choose your sizes from this set of values:
The text was updated successfully, but these errors were encountered: