Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mislaid blocks of code #53

Open
sima-qian opened this issue May 23, 2019 · 0 comments
Open

Mislaid blocks of code #53

sima-qian opened this issue May 23, 2019 · 0 comments

Comments

@sima-qian
Copy link

I've noticed in a couple of places there exist two very similar blocks of code -- generally the first block has a problem and the second block does not. An example in /src/controllers/addContact.js: the getEventList() -> getGroupList() chain is duplicated. The first time, neither is passed an argument, which causes an error; the second time both are passed the user's email address and the queries are able to execute.

Commenting out the first block means the request is deal with successfully, the event list and group list dropdowns are populated and the server doesn't crash.

My best guess is this is a merge that has gone awry somewhere?

The other file where this occurs is /src/controllers/postGroup.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant