Looping over object properties

[oliverjam]

week4-team-pokedex/src/getCommonNames.js

Line 3 in 39d14ef

for (let i = 0; i < 24698; i++) {

I think you've hardcoded 24698 here because that's how many properties are in the JSON?

If you need to loop over an object there are a few options:

1. Keep using a for loop but use json.length instead of hard-coding the number.
2. Use a for..of loop which will loop over an object directly.
3. Get an array of all the keys, values or both using either Object.keys(json), Object.values(json) or Object.entries(json)

e.g.

const getCommonNames = json => {
  const array = Object.values(json).map(value => value.common_name);
  return array;
};

[oliverjam]

Oh sorry just realised that your json is an array not an object. Most of the above still applies, but you don't need the Object.keys etc. You can just map over the array directly with json.map(item => item.common_name)