No tests for front-end code

[finnhodgkin]

You should still be writing tests for the front-end code.

This week was concentrated on Node so it's not so big a deal, but generally you should have tests for your front-end code as well as your backend.

[aajour]

can you please explain what you mean with front-end exactly?

[finnhodgkin]

Front-end code is any javascript running in the browser.

So for this project index.js and svgs.js are front-end code.

[finnhodgkin]

On a related note all tests should run on npm test. See:

FACG2/MarvelCode-Week4#22

[Walidmash]

@finnhodgkin but we have 2 test files , one for the backend in src/test.js and we have one for the frontend in public/test.js

[finnhodgkin]

That front-end test file wasn't merged until 9.04am - after I'd started code review and your team should have been reviewing another team's code.

[finnhodgkin]

It also isn't linked in the package.json

All tests should run on npm test so people working on the project can easily check they haven't broken something elsewhere in the app.