Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feel free to use path lib #20

Open
Walidmash opened this issue Aug 3, 2017 · 1 comment
Open

feel free to use path lib #20

Walidmash opened this issue Aug 3, 2017 · 1 comment

Comments

@Walidmash
Copy link

you using 'path' module , however . you dont use its function "join" in

 fs.readFile(__dirname + '/../public/index.html', function(err, data) {

which can be used instead of "+" and helps in removing "/" which not compatible for all OS

@EngAyoosh
Copy link
Contributor

we use it ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants