Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impure functions in uniProcessor.js #12

Open
ZooeyMiller opened this issue Aug 3, 2017 · 1 comment
Open

Impure functions in uniProcessor.js #12

ZooeyMiller opened this issue Aug 3, 2017 · 1 comment

Comments

@ZooeyMiller
Copy link

The functions in uniProcessor.js could easily be made into pure functions if instead of directly referring to countr and UniPath variables, they took them in as arguments.

If you did this, the functions would be pure (data in, data out) functions, which would be easier to test, meaning you could fill out your empty (:cry:) test file.
@mahmoudalwadia
Copy link
Contributor

we will take it into account 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahmoudalwadia @ZooeyMiller