Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customers.notify_me can be a boolean #15

Open
tomduggan85 opened this issue Jul 25, 2018 · 1 comment
Open

Customers.notify_me can be a boolean #15

tomduggan85 opened this issue Jul 25, 2018 · 1 comment

Comments

@tomduggan85
Copy link

nigerian-airlines/server/database/models/customers.js

Line 20 in bb60785

type: DataTypes.STRING(20)

Instead of using a STRING as the datatype of notify_me, you could use a boolean (DataTypes.BOOLEAN), as the only values you'd expect to store there is true or false.
amusameh added a commit that referenced this issue Jul 26, 2018
@amusameh
add mock_data.js file to fill the database and fix db related issues …
681ca30 
…relates #15 #16 #17
@amusameh
Copy link
Collaborator

Yeah it has to be boolean, fixed
thanks

@amusameh amusameh mentioned this issue Jul 26, 2018
Merged
NouraldinS added a commit that referenced this issue Jul 26, 2018
@NouraldinS
Merge pull request #19 from FACG4/db-basic-steup
f6f203a 
Fix the database related issues #15 #16 #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amusameh @tomduggan85