Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GREAT JOB! #19

Open
NouraldinS opened this issue Apr 25, 2018 · 1 comment
Open

GREAT JOB! #19

NouraldinS opened this issue Apr 25, 2018 · 1 comment

Comments

@NouraldinS
Copy link

@amusameh @InassTubail @razan99 @haneenshahwan4
I'm sorry I've skipped lots of your code, this means fewer issues for you guys, so I'll compact the rest of what's in my mind in the following:

  1. You haven't checked for the token on each request, so I could change the token and nothing would happen.
  2. These issues are all relevant to you, so please look them all up:

FACG4/w6_Stop_Go_Cont#81
FACG4/w6_Stop_Go_Cont#80
FACG4/w6_Stop_Go_Cont#79
FACG4/w6_Stop_Go_Cont#77
FACG4/w6_Stop_Go_Cont#75
FACG4/w6_Stop_Go_Cont#74
FACG4/w6_Stop_Go_Cont#67
FACG4/w6_Stop_Go_Cont#66

  1. I loved your front-end error handling and showing your user the errors in a descriptive message.
  2. You've met the week's goal 👏 🎆
  3. Thank you, I didn't spend the time to review your entire code because it was so relieving. Almost everything works perfectly. Just make sure to write more tests, use heroku, travis, eslint... etc.
  4. You guys honestly did a great job. Thnx!
@razan99
Copy link
Contributor

razan99 commented Apr 26, 2018

thank you Noureldean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants