Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Unity 2022.3 #21

Merged
merged 7 commits into from
May 19, 2024
Merged

Upgrade to Unity 2022.3 #21

merged 7 commits into from
May 19, 2024

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Apr 29, 2024

Closes #20
Closes #18
Closes #16

@Garanas

Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of files are deleted that feel unrelated to upgrading to the latest version. Includes for example the license, the visual studio project, the readme and the entire structure folder.

@MrRowey
Copy link
Member Author

MrRowey commented Apr 29, 2024

Didn't mean to yeet the licence & Structre file will re-add that back in xD

But all that is needed to Complie the Editor in Unity is the following folders below
image

I've tried this multiple times now even when opening in Unity Now it doesn't even add the single files like in the base repo currently

@Garanas
Copy link
Member

Garanas commented Apr 29, 2024

But the visual studio project (sln/csproj) contains all the project settings. How would one edit the code and build it without it?

Unless Unity took a different approach, of course.

@MrRowey
Copy link
Member Author

MrRowey commented Apr 29, 2024

image
It uses Visual Studio Code Editor

jsut open up the Folder in VSCode and your able to edit all the files

@MrRowey
Copy link
Member Author

MrRowey commented Apr 29, 2024

Ive added back in the VS Files so they are their but it can be done via VSCode

@Garanas
Copy link
Member

Garanas commented Apr 29, 2024

Just because it works via another tool doesn't mean we should drop Visual Studio - that's a separate concern, unrelated to upgrading the version of Unity

@MrRowey MrRowey requested a review from Garanas April 29, 2024 11:47
@BlackYps
Copy link

BlackYps commented May 6, 2024

so uhh, how would I possiby review this immense amount of changes?

@MrRowey
Copy link
Member Author

MrRowey commented May 7, 2024

so uhh, how would I possiby review this immense amount of changes?

This PR has so many changes due to the major change in the Unity engine this does not include any new feature additions apart from removing the play-in-game buttons.

The Best way to probably review the changes is to try the new version of the editor for Windows which is currently available for testing
https://github.com/MrRowey/FAForeverMapEditor/releases/tag/WindowsPreRelses

Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to work fine; I can't possibly verify everything of course. There are too many changes for that.

@BlackYps
Copy link

I gave the mappers time until the 19th to provide feedback, but so far I haven't heard of any issues either

@MrRowey
Copy link
Member Author

MrRowey commented May 14, 2024

I gave the mappers time until the 19th to provide feedback, but so far I haven't heard of any issues either

That's fine we can wait for that then we can merge it in and do the new production build

@Garanas Garanas merged commit f0fa197 into FAForever:master May 19, 2024
@MrRowey MrRowey deleted the UnityVersionUpgrade branch May 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants