Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized AtomsToData class #516

Closed
emsunshine opened this issue Jun 15, 2023 · 2 comments
Closed

Generalized AtomsToData class #516

emsunshine opened this issue Jun 15, 2023 · 2 comments
Labels
dont-close enhancement New feature or request

Comments

@emsunshine
Copy link
Contributor

emsunshine commented Jun 15, 2023

Recent changes and discussions (such as #492, #513, and #520) have highlighted the need for a generalizable way to transform ASE atoms objects into torch_geometric Data objects. Such a class would effectively replace AtomsToGraphs.

It would be useful if this function was capable of including many different properties without adding tons of keyword arguments (the way AtomsToGraphs currently has r_energy, r_forces, r_pbc, etc.). It may even be possible to include arbitrary properties. Perhaps it could use the new metadata guesser in some way?

This functionality would reduce the entry barrier for people building models/trainers for properties other than officially supported ones (energy and forces). It would also be good from a code readability standpoint since, in practice, AtomsToGraphs is currently most often used for things other than turning atoms into graphs.

@emsunshine emsunshine added the enhancement New feature or request label Jun 15, 2023
@github-actions
Copy link

This issue has been marked as stale because it has been open for 30 days with no activity.

@mshuaibii
Copy link
Collaborator

PR #622 now provides support for defining arbitrary properties that we want to get written into the data object (r_data_keys)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-close enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants