Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config trainer is overwritten to "forces" or "energy" #543

Closed
hannahlawrence opened this issue Jul 26, 2023 · 3 comments
Closed

Config trainer is overwritten to "forces" or "energy" #543

hannahlawrence opened this issue Jul 26, 2023 · 3 comments
Assignees

Comments

@hannahlawrence
Copy link

I wrote a custom trainer (modifying the forces_trainer.py file) and registered it under a new name, then passed it in to my config. However, this processing line overwrites whatever the true trainer name was in the config to "forces" or "energy", based on the task. The code still uses the correct trainer, but this is slightly confusing behavior from a logging perspective, such looking at wandb logs to verify which trainer was actually used in a given run. Thanks!

@mshuaibii
Copy link
Collaborator

Thanks for flagging! I'll make sure to address these changes in the new OCP trainer #520.

@mshuaibii mshuaibii self-assigned this Jul 27, 2023
@mshuaibii mshuaibii mentioned this issue Jul 27, 2023
19 tasks
@github-actions
Copy link

This issue has been marked as stale because it has been open for 30 days with no activity.

@mshuaibii
Copy link
Collaborator

We've now removed all "forces/energy" trainer definition. Everything is now ocp and supportive of any arbitrary property defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants