Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptimizableBatch and stress relaxations #718

Open
wants to merge 119 commits into
base: main
Choose a base branch
from
Open

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented May 28, 2024

Add functionality to include cell relaxations in structural relaxations for models that implement stress prediction. This PR also enables batch calculations with ASE optimizers.

  • Extends the OCPCalculator to enable stress predictions, and relaxations with ASE filters.
  • Extends core.common.relaxation.ml_relax to enable batch relaxations including stress.
  • Includes a new class OptimizableBatch that can be used with ASE optimizers or with the existing LBFGS implementation
  • Includes a UnitCellOptimizableBatch to allow batch stress relaxations
  • Includes a ExpCellOptimizableBatch to allow batch stress relaxations will do this in a separate PR

TODO

  • Unit tests (missing tests with unit cell relaxation, pending models that can predict stress)

@lbluque lbluque marked this pull request as draft May 28, 2024 19:06
@lbluque lbluque requested a review from mshuaibii August 26, 2024 21:56
@zulissimeta zulissimeta self-requested a review November 22, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Minor version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants