Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hydra freeze backbone option #898

Merged
merged 1 commit into from
Oct 29, 2024
Merged

add hydra freeze backbone option #898

merged 1 commit into from
Oct 29, 2024

Conversation

misko
Copy link
Collaborator

@misko misko commented Oct 28, 2024

Add an option to hydra to freeze the backbone from parameter updates

@misko misko requested a review from rayg1234 October 28, 2024 02:05
@misko misko added enhancement New feature or request minor Minor version release labels Oct 28, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/fairchem/core/models/base.py 88.73% <100.00%> (+0.24%) ⬆️

rayg1234
rayg1234 reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@rayg1234 rayg1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would need a different method for the grad force finetuning right?

@rayg1234
Copy link
Collaborator

we would need a different method for the grad force finetuning right?

opps, nm

@misko misko added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit a2a53ee Oct 29, 2024
10 of 11 checks passed
@misko misko deleted the hydra_freeze_backbone branch October 29, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayg1234 rayg1234 rayg1234 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request minor Minor version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misko @rayg1234