-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CORS configuration #578
Conversation
9c8ff37
to
8ac2170
Compare
@dennisvang could you please rebase based on the updated develop where dependencies were updated (so it should also pass the security checks) and check it still works as desired? Also, are you OK to switch from bugfix to chore? Or it was not working properly before the change? |
Hi @MarekSuchanek thanks for picking this up. I'll rebase a.s.a.p.
The change was prompted by #549 so I guess bugfix would apply. |
9d92e2b
to
c8ab6f6
Compare
c8ab6f6
to
5604d17
Compare
@MarekSuchanek The Snyk Maven check keeps failing to authenticate, for some unknown reason. The PR does not change anything related to github actions. Any ideas? |
That is weird... I would guess it is because you have external branch and cannot use the secrets of this repo (SNYK_TOKEN) but Snyk for Docker image seems to work 🤔 In any case, if that is OK for you - we can squash-merge this now and check Snyk later eventually. |
Replaces legacy
CORSFilter
implementation by modern configuration based onCorsRegistry
.This uses the same CORS settings as the original implementation, viz. allow all origins.
I did not check if it is desirable and/or safe to keep those settings. May be a good idea to review that choice.
fixes #549