You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have being exploring the Solution class, and I found these possible issues:
When doing an EntryPoint for a solution, if you try to modify the solutes, an error will appear and the entry will not work anymore. I know the proper way will be to add a component, but the solvent list should not be editable.
The solute and the solvent should be add at the same time (without saving in between), because then the molar concentration cannot be calculated. So maybe there should be a safe check to only calculate the molar concentration when both solvent and solute are not empty.
In the ThinFilmStack class you add Substrate and layers, instead of components so it works the other way around as solutions, which I don't think should be the case.
Hi @GarzonDiegoFEUP, your feedback on the solution classes is much appreciated.
You are right that solute and solvent should be non-editable to avoid confusion. We don't have an annotation to make sub-sections non-editable. But here's an issue you can follow regarding it: https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/issues/2151
The molar concentration should be calculated if the volume is available. If you add just a solute and save it, the molar concentration should not work because the volume is missing. In fact as I test it now, I get a warning saying "Volume of the solution is missing, can not calculate the concentration of the component ClNa." as expected, but I also get an unexpected error from self.combine_components(self.solutes, logger). I will take a look into this. Add solutions category and resolve bug in combine_components #106
I have being exploring the Solution class, and I found these possible issues:
Thank you @aalbino2 @ka-sarthak !!
The text was updated successfully, but these errors were encountered: