Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_archive function #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

create_archive function #35

wants to merge 1 commit into from

Conversation

aalbino2
Copy link
Collaborator

dict_nan_equal is checking if two dicts are equal, ignoring any NaN value.

This is necessary because in Python it is always NaN != Nan

@aalbino2 aalbino2 linked an issue Feb 23, 2024 that may be closed by this pull request
create archive function #34
Open
@aalbino2
Copy link
Collaborator Author

BTW, I'm getting a different error when reprossing for the second time. It is something connected to the normalization of the EntityReference class. It is not finding anymore the context of the referenced Entry. I'll check it

@ka-sarthak
Copy link
Collaborator

I recently created entries in the nomad-polymerization-reactions plugin by creating archive.yaml files and adding them to the upload folder. The nomad parser can then make the entries for us. Regarding overwriting, we can put some logic for updating the archive.yaml files rather than the entries. I think @hampusnasstrom also had a similar idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hampusnasstrom hampusnasstrom Awaiting requested review from hampusnasstrom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create archive function
2 participants
@aalbino2 @ka-sarthak