-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XRD Hackathon: using a nexus
subsection
#135
Comments
@budschi FYI: The PR #116 has not been yet merged into the main branch. The creation of a nexus sub-section in the EntryArchive or in EntryArchive/data is not an issue. Currently, in PR #116 data comes from the Nexus file using the hdf5 reference recipe. There are no nexus subsections anywhere. I tested the XRD measurement plugin there are no issues. @ka-sarthak would you please confirm it? |
Sandor and I discussed the following today:
|
@budschi thanks for sharing the input. After discussions with @aalbino2, it's still not clear if we should create an entry for To share the line of thought, I assume for the First Attempt that we are creating a nexus entry for First attemptI am rewriting the 3 situations (or workflows) @budschi mentioned above just to be on the same page:
Situation 2 and 3 have similar end states, but different starting points. In situation 2, ELN can be populated with data from Situation 2
The ELN normalization will do the following:
Situation 3The goal is to get all data from the The ELN normalization will do the following:
Parser modificationFor situation 3, we will have to add a matching parser for This brings me to the Second Attempt where we do not create an entry for the Second AttemptRather than going directly into the normalization, we use the parser to handle different types of file. The matching parser for raw XRD files like Situation 2
From here on, we have a common interface for the ELN which either deals with a
Situation 3
Sorry for the long albeit non-circumventable comment! |
@hampusnasstrom @aalbino2 I am leaning towards "Second Attempt". It will be great to have your input before I start implementing. |
Also, in this thread, we are using |
I think I need this described in person. |
I'm sorry. Last week I was busy with SPM paper writing, it is still not completely done and planned to continue until next month, but I think I can give my input Regarding solution-2, the PR #116 has most of the work done. For solution-3, I can join to the meeting you arrange for this issue. |
We met in Area A today and decided to tackle situation 2 for now. Essentially having the following workflow implemented:
As @RubelMozumder mentioned, the nexus side of this is available in #116. We will need to check if it's still compatible with the current state of pynxtools. The modifications in the ELN schema will be done in #118. |
Since the
nexus
section resolved intodata
recently, we have to use now a subsection which we could callnexus
instead of thenexus
section we had beofore. Otherwise there will be an overwriting conflict.@sanbrock @markus1978
The text was updated successfully, but these errors were encountered: