Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow merge_section to merge child classes too #142

Open
aalbino2 opened this issue Dec 2, 2024 · 0 comments · May be fixed by #143
Open

allow merge_section to merge child classes too #142

aalbino2 opened this issue Dec 2, 2024 · 0 comments · May be fixed by #143
Assignees
@aalbino2

Comments

@aalbino2
Copy link
Contributor

aalbino2 commented Dec 2, 2024

When we want to import a recipe into its correspondent activity, or some king of template archive into another, merge_Section is raising an error if the sub_section_def are not the very same.

E.g. SubstrateHolderPosition and FilledSubstrateHolderPosition and so on

I sketched a solution that I will propose in a MR connected to this issue @ka-sarthak @hampusnasstrom @budschi
@aalbino2 aalbino2 self-assigned this Dec 2, 2024
@aalbino2 aalbino2 linked a pull request Dec 2, 2024 that will close this issue
allow merge_section to merge children classes #143
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalbino2 aalbino2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow merge_section to merge children classes FAIRmat-NFDI/nomad-measurements
1 participant
@aalbino2