Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XRF measurents #88

Open
Pepe-Marquez opened this issue Mar 20, 2024 · 4 comments · May be fixed by #90
Open

Add XRF measurents #88

Pepe-Marquez opened this issue Mar 20, 2024 · 4 comments · May be fixed by #90
Assignees

Comments

@Pepe-Marquez
Copy link
Contributor

We have a couple of use cases of groups that are using XRF either as mapping or as a single measured point. We need a schema and parsers to cope with this. File formats should account for the tornado .spx format and for the files provided by the UIBK colleagues: https://fileshare.uibk.ac.at/d/1a200e720a29450f9add/
@hampusnasstrom, feel free to add info and comment on this. I believe there is already a reader for the .spx files. @RoteKekse, @yaruwangway, is there already a schema for Thomas's lab?

@RoteKekse
Copy link
Collaborator

Hey there is a parser which is quite user oriented. it takes the results of the data analysis and the spx files and reads position thickness and composition information

so proper schema should also include what model was used and other data :)

@Pepe-Marquez
Copy link
Contributor Author

Hey there is a parser which is quite user oriented. it takes the results of the data analysis and the spx files and reads position thickness and composition information

so proper schema should also include what model was used and other data :)

I think starting with this would be already very good. Do you have a link to the parser @RoteKekse? This would be helpful for @fabianschoeppach to get inspired.

@RoteKekse
Copy link
Collaborator

RoteKekse commented Mar 21, 2024

ah fabian should know already but i can repost here:
the parsing is done here:https://github.com/nomad-hzb/hzb-combinatorial-libraries-plugin/blob/main/src/hzb_combinatorial_libraries/schema.py#L131
the schema is here: https://github.com/nomad-hzb/nomad-baseclasses/blob/main/baseclasses/characterizations/xrf.py

keep in mind that i modified the schema right now in a way that elasticsearch is not over limit, since there are only 10000 values able to b eregistered per nomad entry my orginal schema was too much for 625 XRF spot measurements with 20 qunatites per measurements :D

@fabianschoeppach
Copy link
Collaborator

FYI: I created the branch '88-add-xrf-measurements' last week and did some work similar to the xrd stuff on there.
I got the plugin and schema to run properly, e.g. I can use the create upload from schema.
Still unsure about how to properly save the extracted data in the end.

@fabianschoeppach fabianschoeppach linked a pull request Apr 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants