Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Am 2 #29

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Am 2 #29

merged 4 commits into from
Jun 20, 2024

Conversation

ahm531
Copy link
Collaborator

@ahm531 ahm531 commented Jun 19, 2024

This PR updates the "Install This Plugin" documentation page to provide comprehensive, self-contained instructions for users. The changes include:

  1. Self-Contained Instructions: Rewritten to ensure all necessary steps are included within the documentation, eliminating the need to follow external links.

  2. Content Adaptation: Text adapted from Tutorial 13 git page and modified specifically for the UniSysCat plugin.

  3. Visual Guidance: Added GIFs to visually guide users through the installation steps, enhancing clarity and usability.

  4. GIF Integration: Included GIFs directly within the documentation page for seamless reference.

@ahm531 ahm531 requested a review from Pepe-Marquez June 19, 2024 20:08
Pepe-Marquez
Pepe-Marquez approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@Pepe-Marquez Pepe-Marquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition! It is very clear! I wonder if it should even go a bit adapted to the main NOMAD docs.

I have added very minor changes myself.

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9592523722

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9578916457: 0.0%
Covered Lines: 27
Relevant Lines: 27
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9592602481

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9578916457: 0.0%
Covered Lines: 27
Relevant Lines: 27
💛 - Coveralls

@Pepe-Marquez Pepe-Marquez merged commit c4ee244 into main Jun 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pepe-Marquez Pepe-Marquez Pepe-Marquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahm531 @coveralls @Pepe-Marquez