Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpes app #38

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Mpes app #38

wants to merge 2 commits into from

Conversation

rettigl
Copy link
Collaborator

@rettigl rettigl commented Jan 8, 2025

Development branch for NXmpes app
See #37

@rettigl rettigl linked an issue Jan 8, 2025 that may be closed by this pull request
13 tasks
@lukaspie
Copy link
Contributor

@rettigl thanks for starting this. We should think how/where we want to ship this. If we have it as part of pynxtools-mpes, we will not have the app when we only use pynxtools-xps without the mpes package.

I see different ways we could go:

  1. we require pynxtools-mpes within the dependencies of pynxtools-xps so the app always gets installed
  2. we make a separate repo just for the app (like pynxtools-mpes-app and add this here and in ´pynxtools-xps´ in the deps)
  3. we merge pynxtools-mpes and pynxtools-xps again into one repository/package

What are your opinions on this?

@rettigl
Copy link
Collaborator Author

rettigl commented Jan 16, 2025

Maybe it indeed would make sense to have also two separate apps. E.g. searching for specific core level energies or so is interesting for NXxps, but for NXmpes not so much...
Difficulty is to keep the part of development that is shared synced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NXmpes Nomad search app
2 participants