Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hardcoding from Raman Reader #3

Open
RonHildebrandt opened this issue Sep 11, 2024 · 0 comments
Open

Remove Hardcoding from Raman Reader #3

RonHildebrandt opened this issue Sep 11, 2024 · 0 comments

Comments

@RonHildebrandt
Copy link
Collaborator

According to @lukaspie suggestion

Just a general note here: this CONVERT_DICT will be problematic in the long run once you have files from different detectors/samples because you are essentially hardcoding their name here. You could simpy write detector_TYPE[detector_DU970BV] in your ELN and skip the replacement here (or just use generic "Detector": "detector_TYPE[detector]").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant