Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to add many weights in a binned dataframe, e.g. wildcarding #121

Open
benkrikler opened this issue May 5, 2020 · 0 comments

Comments

@benkrikler
Copy link
Member

At the moment, each weight needs to be specified in advance to build the output dataframe. This makes the configuration files very long in many cases, and can lead to bugs if an important weight is missed out by mistake. It would be good to add a way to specify an expression which automatically identifies which branches should be used for weights, e.g. via a wildcard.

Risks / challenges

  • What is the right way to include and exclude weights via an expression
  • This potentially introduces a new "mini-language" if we need to be able to match some weights but not others
  • When is this list expanded?
    • If it is expanded at run-time, this breaks the static DAG workflow model
    • If it is expanded at launch-time, this requires a possible pre-expansion step and can only be done if 1) all files have the same branches, and 2) all branches are known in advance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant