Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 여정 키워드 검색, 조회, 삭제 API 구현 #9

Merged
merged 19 commits into from
Oct 26, 2023
Merged

feat: 여정 키워드 검색, 조회, 삭제 API 구현 #9

merged 19 commits into from
Oct 26, 2023

Conversation

YurimYang
Copy link

@YurimYang YurimYang commented Oct 25, 2023 •
edited
Loading

개발 내용

  1. 여정 키워드 검색 카카오 API 구현 완료
  2. 여정 조회 API 구현 완료
  3. 여정 삭제 API 구현 완료
  4. 여정 키워드 검색 API 테스트 완료
  5. 여정 조회 API 테스트 완료
  6. 여정 삭제 API 테스트 완료
  7. REST DOCS 적용 완료
  8. 리펙토링(w/주석) 완료

@YurimYang YurimYang changed the base branch from main to develop October 25, 2023 15:49
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Test Results

44 tests  +20   44 ✔️ +20   2s ⏱️ ±0s
32 suites +15     0 💤 ±  0 
32 files   +15     0 ❌ ±  0 

Results for commit 65df02f. ± Comparison against base commit 4639c00.

♻️ This comment has been updated with latest results.

dldmldlsy
dldmldlsy reviewed Oct 25, 2023
View reviewed changes
Copy link

@dldmldlsy dldmldlsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦게까지 수고하셨씁니당 👍😊👍

src/main/java/com/fc/toy_project2/domain/itinerary/controller/ItineraryGetDeleteController.java Outdated Show resolved Hide resolved
JeongUijeong
JeongUijeong reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@JeongUijeong JeongUijeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇 가지 코멘트 달아뒀습니다 🙂

src/main/java/com/fc/toy_project2/domain/itinerary/controller/ItineraryGetDeleteController.java Outdated Show resolved Hide resolved
src/main/java/com/fc/toy_project2/domain/itinerary/service/ItineraryGetDeleteService.java Outdated Show resolved Hide resolved
src/test/java/com/fc/toy_project2/itinerary/unit/controller/ItineraryRestControllerTest.java Outdated Show resolved Hide resolved
@YurimYang YurimYang added 📚document 문서 🛠️feature 기능 개발 🧑🏻‍🔧fix 오류 수정 🚧refactoring 리팩토링 labels Oct 26, 2023
@YurimYang YurimYang merged commit 5e9626d into develop Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongUijeong JeongUijeong JeongUijeong approved these changes

@dldmldlsy dldmldlsy dldmldlsy approved these changes

Assignees

@YurimYang YurimYang

Labels
📚document 문서 🛠️feature 기능 개발 🧑🏻‍🔧fix 오류 수정 🚧refactoring 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YurimYang @dldmldlsy @JeongUijeong