New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Apply clean code and solid practice #73

Open

lucasA27 opened this issue Apr 6, 2022 · 1 comment

Assignees

Labels

Collaborator

lucasA27 commented Apr 6, 2022 •

edited

Loading

Is your feature request related to a problem? Please describe.
It is necessary that some codes have clean code and solid application

Describe the solution you'd like

SRP applied to component:
https://github.com/FGA-GCES/houdini/blob/main/app/javascript/components/form_fields/TextField.tsx

Clean code practices applied to the files:
https://github.com/FGA-GCES/houdini/blob/main/app/javascript/legacy/components/address-autocomplete-fields.js https://github.com/FGA-GCES/houdini/blob/main/app/javascript/legacy/components/number-input.js
https://github.com/FGA-GCES/houdini/blob/main/app/javascript/donate-button/donate-button.v2.ts

Branch

https://github.com/FGA-GCES/houdini/tree/solid-and-clean-code

lucasA27 added the enhancement label

github-actions bot commented Apr 6, 2022

Thanks for submitting your first issue to Houdini!

lucasA27 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment