Debouncing boolean #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiloDavis
suggested changes
Jan 24, 2017
| @@ -0,0 +1,6 @@ | |||
| package lib; | |||
|
|
|||
| public interface DebouncedBoolean { | |||
There was a problem hiding this comment.
Called DebouncedBoolean, not DebouncingBoolean
| * @param windowSize sets size for the queue | ||
| * @param x boolean passed to initialize the queue | ||
| */ | ||
| public DebouncingBoolean(int windowSize, boolean x){ |
There was a problem hiding this comment.
This parameter should be named default
| public DebouncingBoolean(int windowSize, boolean x){ | ||
| this.windowSize = windowSize; | ||
| queue = new LinkedList<Boolean>(); | ||
| while(queue.size() < windowSize){ |
There was a problem hiding this comment.
Initialize count to +windowSize or -windowSize depending on default
| */ | ||
| public void add(boolean b){ | ||
| if (b){ | ||
| queue.removeFirst(); |
There was a problem hiding this comment.
Move this out of the if, but you should also change count
| public class DebouncingBoolean implements DebouncedBoolean{ | ||
| private static LinkedList<Boolean> queue; | ||
| private static int windowSize; | ||
| private boolean count; |
There was a problem hiding this comment.
This should be an int keeping track of how many true or false values have been added
| /** | ||
| * @return count boolean that determines if the queue is true or false | ||
| */ | ||
| public boolean get(){ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debouncing Boolean class
Deboucing Boolean test case