From 8f3d99b4957c2b424766ead7202932c2eecb4276 Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Tue, 9 Jan 2024 09:58:00 +0200 Subject: [PATCH 1/2] bgpd: Drop BGP_DEBUG_PACKET_SEND_DETAIL/BGP_DEBUG_PACKET_SEND consts Not used anywhere. Signed-off-by: Donatas Abraitis --- bgpd/bgp_debug.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/bgpd/bgp_debug.h b/bgpd/bgp_debug.h index 1fc2a87e2ce1..dfd9a2a4ad64 100644 --- a/bgpd/bgp_debug.h +++ b/bgpd/bgp_debug.h @@ -127,9 +127,6 @@ struct bgp_debug_filter { #define BGP_DEBUG_EVPN_MH_ES 0x01 #define BGP_DEBUG_EVPN_MH_RT 0x02 -#define BGP_DEBUG_PACKET_SEND 0x01 -#define BGP_DEBUG_PACKET_SEND_DETAIL 0x02 - #define BGP_DEBUG_GRACEFUL_RESTART 0x01 #define BGP_DEBUG_BFD_LIB 0x01 From 546fe3144c06131c95b32938c4a2eafd8f5ff64c Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Tue, 9 Jan 2024 10:06:36 +0200 Subject: [PATCH 2/2] bgpd: Change printing format `show debugging` for `debug bgp updates` Before: ``` BGP debugging status: BGP updates debugging is on (inbound) for 127.0.0.1 with prefix-list rn-dummy 192.168.10.18 with prefix-list rn-dummy 1.1.1.1 ``` After: ``` BGP debugging status: BGP updates debugging is on (inbound) for: 127.0.0.1 with prefix-list rn-dummy 192.168.10.18 with prefix-list rn-dummy 192.168.10.20 ``` Signed-off-by: Donatas Abraitis --- bgpd/bgp_debug.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bgpd/bgp_debug.c b/bgpd/bgp_debug.c index 138ffedb2956..816b9217e27e 100644 --- a/bgpd/bgp_debug.c +++ b/bgpd/bgp_debug.c @@ -234,10 +234,10 @@ static void bgp_debug_list_print(struct vty *vty, const char *desc, vty_out(vty, "%s", desc); if (list && !list_isempty(list)) { - vty_out(vty, " for"); + vty_out(vty, " for:\n"); for (ALL_LIST_ELEMENTS(list, node, nnode, filter)) { if (filter->host) - vty_out(vty, " %s", filter->host); + vty_out(vty, " %s", filter->host); if (filter->plist_name) vty_out(vty, " with prefix-list %s", @@ -247,6 +247,8 @@ static void bgp_debug_list_print(struct vty *vty, const char *desc, bgp_debug_print_evpn_prefix(vty, "", filter->p); else if (filter->p) vty_out(vty, " %pFX", filter->p); + + vty_out(vty, "\n"); } }