Merge pull request #14578 from opensourcerouting/fix/coverity_1566808

bgpd: Remove redundant check for bgp against NULL
FRRouting · Oct 12, 2023 · 202a0f7 · 202a0f7
2 parents ed262d0 + 4e365c5
commit 202a0f7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/bgpd/bgp_mplsvpn.c b/bgpd/bgp_mplsvpn.c
@@ -1225,8 +1225,9 @@ leak_update(struct bgp *to_bgp, struct bgp_dest *bn,
 	new->extra->vrfleak->parent = bgp_path_info_lock(parent);
 	bgp_dest_lock_node(
 		(struct bgp_dest *)parent->net);
-	if (bgp_orig)
-		new->extra->vrfleak->bgp_orig = bgp_lock(bgp_orig);
+
+	new->extra->vrfleak->bgp_orig = bgp_lock(bgp_orig);
+
 	if (nexthop_orig)
 		new->extra->vrfleak->nexthop_orig = *nexthop_orig;