bgpd: fix link_state_hash_cmp()

Fix comparaison of link state attributes pointers in link_state_hash_cmp(). > CID 1568379 (#1 of 1): Logically dead code (DEADCODE) > dead_error_line: Execution cannot reach this statement: return false;. Fixes: 8b531b1 ("bgpd: store and send bgp link-state attributes") Signed-off-by: Louis Scalbert <[email protected]>
FRRouting · Sep 28, 2023 · 25408c8 · 25408c8
1 parent dae5791
commit 25408c8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
@@ -780,7 +780,7 @@ static bool link_state_hash_cmp(const void *p1, const void *p2)
 
 	if (!link_state1 && link_state2)
 		return false;
-	if (!link_state1 && link_state2)
+	if (link_state1 && !link_state2)
 		return false;
 	if (!link_state1 && !link_state2)
 		return true;