zebra: clarify error when calling zebra_nhg_rib_find_nhe()

Display a specific log message when the rt_nhe parameter is not set at all. Signed-off-by: Philippe Guibert <[email protected]>
FRRouting · Nov 27, 2023 · 3778824 · 3778824
1 parent 6d0c978
commit 3778824
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/zebra/zebra_nhg.c b/zebra/zebra_nhg.c
@@ -1526,7 +1526,13 @@ zebra_nhg_rib_find_nhe(struct nhg_hash_entry *rt_nhe, afi_t rt_afi)
 {
 	struct nhg_hash_entry *nhe = NULL;
 
-	if (!(rt_nhe && rt_nhe->nhg.nexthop)) {
+	if (!rt_nhe) {
+		flog_err(EC_ZEBRA_TABLE_LOOKUP_FAILED,
+			 "No nhg_hash_entry passed to %s", __func__);
+		return NULL;
+	}
+
+	if (!rt_nhe->nhg.nexthop) {
 		flog_err(EC_ZEBRA_TABLE_LOOKUP_FAILED,
 			 "No nexthop passed to %s", __func__);
 		return NULL;