From 51bfbe3b2d6b21726f493bf651d17e1ed8064d75 Mon Sep 17 00:00:00 2001 From: Philippe Guibert Date: Thu, 28 Mar 2024 15:56:19 +0100 Subject: [PATCH] topotests: fix ignore routes with linkdown In topotest, a given interface has only the ignore routes bit turned on for IPv6 only, whereas topotest is expected to turn it on for all address families. > # show interface > Interface r2-r3-eth2 is up, line protocol is up > [..] > flags: > Ignore all v6 routes with linkdown > Type: Ethernet > [..] This is because the only the 'default' ipv6 ignore sysctl is set to 1. Use the /proc/sys/net/conf//default/ignore_routes_with_linkdown flag instead, to have same behaviour for ipv4 and ipv6. Fixes: 4958158787ce ("tests: micronet: update infra") Signed-off-by: Philippe Guibert --- tests/topotests/lib/topotest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/topotests/lib/topotest.py b/tests/topotests/lib/topotest.py index edcfb0a55f6b..19ceff88e697 100644 --- a/tests/topotests/lib/topotest.py +++ b/tests/topotests/lib/topotest.py @@ -1318,8 +1318,8 @@ def fix_netns_limits(ns): if version_cmp(platform.release(), "4.20") >= 0: sysctl_assure(ns, "net.ipv6.route.skip_notify_on_dev_down", 1) - sysctl_assure(ns, "net.ipv4.conf.all.ignore_routes_with_linkdown", 1) - sysctl_assure(ns, "net.ipv6.conf.all.ignore_routes_with_linkdown", 1) + sysctl_assure(ns, "net.ipv4.conf.default.ignore_routes_with_linkdown", 1) + sysctl_assure(ns, "net.ipv6.conf.default.ignore_routes_with_linkdown", 1) # igmp sysctl_atleast(ns, "net.ipv4.igmp_max_memberships", 1000)