From 5241a3652b109bb5673e75cba7098ecd2cbf4970 Mon Sep 17 00:00:00 2001 From: Philippe Guibert Date: Mon, 28 Oct 2024 16:04:45 +0100 Subject: [PATCH] bgpd: fix blank line in running-config with bmp listener cmd An extra blank line is added in show running-config with BMP: > ubuntu2204hwe(config)# router bgp 65500 > ubuntu2204hwe(config-router)# bmp targets tgt > ubuntu2204hwe(config-bgp-bmp)# bmp monitor ipv4 unicast pre-policy > ubuntu2204hwe(config-bgp-bmp)# bmp listener 192.0.2.100 port 44 > ubuntu2204hwe(config-bgp-bmp)# do show running-config > > router bgp 65500 > [..] > bmp targets tgt > bmp monitor ipv4 unicast pre-policy > <-- blank line > bmp listener 192.0.2.100 port 44 > exit Remove the blank line. Fixes: ed18356f1f2d ("bgpd/bmp: BMP implementation") Signed-off-by: Philippe Guibert (cherry picked from commit 9a33ee18bfe2769e173911d69cee64b78143184b) --- bgpd/bgp_bmp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bgpd/bgp_bmp.c b/bgpd/bgp_bmp.c index 1de48a072a91..0ad85c984d8d 100644 --- a/bgpd/bgp_bmp.c +++ b/bgpd/bgp_bmp.c @@ -2769,8 +2769,7 @@ static int bmp_config_write(struct bgp *bgp, struct vty *vty) afi2str_lower(afi), safi2str(safi)); } frr_each (bmp_listeners, &bt->listeners, bl) - vty_out(vty, " \n bmp listener %pSU port %d\n", - &bl->addr, bl->port); + vty_out(vty, " bmp listener %pSU port %d\n", &bl->addr, bl->port); frr_each (bmp_actives, &bt->actives, ba) { vty_out(vty, " bmp connect %s port %u min-retry %u max-retry %u",