bgpd: Fix memory leak when creating BMP connection with a source inte…

…rface Testing done with: ``` for x in $(seq 1 100000); do vtysh -c 'conf' -c 'router bgp' -c 'bmp targets test' -c 'bmp connect localhost port 123 min-retry 100 max-retry 100 source-interface lo'; done ``` Signed-off-by: Donatas Abraitis <[email protected]>
FRRouting · Dec 19, 2024 · 7d19cb5 · 7d19cb5
1 parent 6c3e1e4
commit 7d19cb5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/bgpd/bgp_bmp.c b/bgpd/bgp_bmp.c
@@ -2630,8 +2630,11 @@ DEFPY(bmp_connect,
 	}
 
 	ba = bmp_active_get(bt, hostname, port);
-	if (srcif)
+	if (srcif) {
+		if (ba->ifsrc)
+			XFREE(MTYPE_TMP, ba->ifsrc);
 		ba->ifsrc = XSTRDUP(MTYPE_TMP, srcif);
+	}
 	if (min_retry_str)
 		ba->minretry = min_retry;
 	if (max_retry_str)