Skip to content

Commit

Permalink
bgpd: When using dev build add pointer information to %pBD
Browse files Browse the repository at this point in the history
When building FRR with `--enable-dev-build`.  Add a bit of
code to include the pointer value as part of the output.
Helps with tracking down issues and let's us see more data
when using the dev build option.

New output:

2024/03/08 19:48:56 BGP: [V0J1J-W5RHA] 11.0.20.1/32(0x5759ddf8d7c0) for 11.0.20.1/32

Signed-off-by: Donald Sharp <[email protected]>
  • Loading branch information
donaldsharp authored and ton31337 committed Mar 14, 2024
1 parent 4b512f2 commit 894cb4f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions bgpd/bgp_table.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,11 @@ static ssize_t printfrr_bd(struct fbuf *buf, struct printfrr_eargs *ea,
if (!dest)
return bputs(buf, "(null)");

#if !defined(DEV_BUILD)
/* need to get the real length even if buffer too small */
prefix2str(p, cbuf, sizeof(cbuf));
return bputs(buf, cbuf);
#else
return bprintfrr(buf, "%s(%p)", prefix2str(p, cbuf, sizeof(cbuf)), dest);
#endif
}
3 changes: 2 additions & 1 deletion doc/developer/logging.rst
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,8 @@ bgpd
.. frrfmt:: %pBD (struct bgp_dest *)
Print prefix for a BGP destination.
Print prefix for a BGP destination. When using ``--enable-dev-build`` include
the pointer value for the bgp_dest.
:frrfmtout:`fe80::1234/64`
Expand Down

0 comments on commit 894cb4f

Please sign in to comment.