From b8449b61e10ff5fc5ab5042ca1fde234edfb79d6 Mon Sep 17 00:00:00 2001 From: Vladislav Odintsov Date: Wed, 4 Sep 2024 00:25:55 +0300 Subject: [PATCH] lib: Attach stdout to child only if --log=stdout and stdout FD is a tty. Prior to this commit stdout of a process started in a daemon mode was attached to a calling process. As a result a calling process hung for infinity. Signed-off-by: Vladislav Odintsov --- lib/libfrr.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/libfrr.c b/lib/libfrr.c index 0a575abac6cd..bb3361808af7 100644 --- a/lib/libfrr.c +++ b/lib/libfrr.c @@ -1125,9 +1125,11 @@ static void frr_terminal_close(int isexit) * don't redirect when stdout is set with --log stdout */ for (fd = 2; fd >= 0; fd--) - if (isatty(fd) && - (fd != STDOUT_FILENO || !logging_to_stdout)) + if (logging_to_stdout && isatty(fd) && fd == STDOUT_FILENO) { + /* Do nothing. */ + } else { dup2(nullfd, fd); + } close(nullfd); } } @@ -1213,9 +1215,11 @@ void frr_run(struct event_loop *master) * stdout */ for (fd = 2; fd >= 0; fd--) - if (isatty(fd) && - (fd != STDOUT_FILENO || !logging_to_stdout)) + if (logging_to_stdout && isatty(fd) && fd == STDOUT_FILENO) { + /* Do nothing. */ + } else { dup2(nullfd, fd); + } close(nullfd); }