From ba7130309954fbe8d58854339ca43259149e603a Mon Sep 17 00:00:00 2001 From: Philippe Guibert Date: Fri, 5 Apr 2024 13:52:27 +0200 Subject: [PATCH] bgpd: remove useless control checks about TCP connection When attempting to get the src and destination addresses of a given connection, the API may return the NULL pointer, but further code in bgp_zebra_nexthop_set() already does a check about the given pointer. Relaxing the error code for all the returned adressing. Fixes: 1ff9a340588a ("bgpd: bgpd-fsm-fix.patch") Signed-off-by: Philippe Guibert --- bgpd/bgp_network.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c index dbb34b048fe6..b409cbe706ec 100644 --- a/bgpd/bgp_network.c +++ b/bgpd/bgp_network.c @@ -875,11 +875,7 @@ int bgp_getsockname(struct peer *peer) } peer->su_local = sockunion_getsockname(peer->connection->fd); - if (!peer->su_local) - return -1; peer->su_remote = sockunion_getpeername(peer->connection->fd); - if (!peer->su_remote) - return -1; if (!bgp_zebra_nexthop_set(peer->su_local, peer->su_remote, &peer->nexthop, peer)) {