From c1ce67e26c88e88c7cb3cb239160a188aa6b8897 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Wed, 7 Jun 2023 10:09:27 -0400 Subject: [PATCH] bgpd: Add some color to why nexthop_set failed We are seeing some frequent test failures with setting the nexthop correctly. At this point in time, I have no idea what is going wrong, but I don't have a bunch of information either, so let's add the local and remote values. Signed-off-by: Donald Sharp --- bgpd/bgp_network.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c index e235a61f590e..73fe00c7ab99 100644 --- a/bgpd/bgp_network.c +++ b/bgpd/bgp_network.c @@ -810,8 +810,9 @@ int bgp_getsockname(struct peer *peer) &peer->nexthop, peer)) { flog_err( EC_BGP_NH_UPD, - "%s: nexthop_set failed, resetting connection - intf %s", - peer->host, + "%s: nexthop_set failed, local: %pSUp remote: %pSUp update_if: %s resetting connection - intf %s", + peer->host, peer->su_local, peer->su_remote, + peer->update_if ? peer->update_if : "(None)", peer->nexthop.ifp ? peer->nexthop.ifp->name : "(Unknown)"); return -1;