From d6d49f291c45cf28736f8b2686fd0a401e54533c Mon Sep 17 00:00:00 2001 From: Rafael Zalamena Date: Wed, 31 Jul 2024 10:18:47 -0300 Subject: [PATCH] pimd: fix possible NULL dereference Coverity scan ID: 1598684 Signed-off-by: Rafael Zalamena --- pimd/pim_cmd.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pimd/pim_cmd.c b/pimd/pim_cmd.c index dcfad2a4f81a..f57048c7037f 100644 --- a/pimd/pim_cmd.c +++ b/pimd/pim_cmd.c @@ -2837,13 +2837,14 @@ DEFPY(clear_ip_msdp_peer, clear_ip_msdp_peer_cmd, const struct vrf *vrf; struct pim_msdp_peer *mp; - if (vrfname) { + if (vrfname) vrf = vrf_lookup_by_name(vrfname); - if (vrf == NULL) - return CMD_WARNING; - } else + else vrf = vrf_lookup_by_id(VRF_DEFAULT); + if (vrf == NULL || vrf->info == NULL) + return CMD_WARNING; + pim = vrf->info; for (ALL_LIST_ELEMENTS_RO(pim->msdp.peer_list, node, mp)) { if (mp->peer.s_addr != peer.s_addr)