Merge pull request #17675 from opensourcerouting/fix/memory_leaks_for…

…_strdup bgpd: Fix memory leak when creating BMP connection with a source interface
FRRouting · Dec 19, 2024 · d875d70 · d875d70
2 parents 4a0e8ed + 7d19cb5
commit d875d70
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/bgpd/bgp_bmp.c b/bgpd/bgp_bmp.c
@@ -2630,8 +2630,11 @@ DEFPY(bmp_connect,
 	}
 
 	ba = bmp_active_get(bt, hostname, port);
-	if (srcif)
+	if (srcif) {
+		if (ba->ifsrc)
+			XFREE(MTYPE_TMP, ba->ifsrc);
 		ba->ifsrc = XSTRDUP(MTYPE_TMP, srcif);
+	}
 	if (min_retry_str)
 		ba->minretry = min_retry;
 	if (max_retry_str)