From e42e58118f5065e06ff152d23d63c72c18406e5a Mon Sep 17 00:00:00 2001 From: Acee Date: Fri, 16 Aug 2024 13:49:41 -0400 Subject: [PATCH] ospfd: Fix SA warnings in ospf_packet.c and ospf_vty.c Fix SA warnings in ospf_packet.c and ospf_vty.c. The former was introduced by commit ed480148844259b7e9e30ed92489cdf44085457e. Signed-off-by: Acee --- ospfd/ospf_packet.c | 5 ++--- ospfd/ospf_vty.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/ospfd/ospf_packet.c b/ospfd/ospf_packet.c index 2d15a7ecca33..e336435cbd72 100644 --- a/ospfd/ospf_packet.c +++ b/ospfd/ospf_packet.c @@ -3335,7 +3335,7 @@ static int ospf_make_ls_ack(struct ospf_interface *oi, struct ospf_lsa_list_entry *ls_ack_list_entry; uint16_t length = OSPF_LS_ACK_MIN_SIZE; struct ospf_lsa *lsa; - struct in_addr first_dst_addr; + struct in_addr first_dst_addr = { INADDR_ANY }; /* * For direct LS Acks, assure the destination address doesn't @@ -3346,8 +3346,7 @@ static int ospf_make_ls_ack(struct ospf_interface *oi, if (ls_ack_list_first) first_dst_addr.s_addr = ls_ack_list_first->list_entry_dst.s_addr; - } else - first_dst_addr.s_addr = INADDR_ANY; + } frr_each_safe (ospf_lsa_list, ls_ack_list, ls_ack_list_entry) { lsa = ls_ack_list_entry->lsa; diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c index bfb935b132f8..13138914fa66 100644 --- a/ospfd/ospf_vty.c +++ b/ospfd/ospf_vty.c @@ -8041,7 +8041,7 @@ static int ospf_vty_dead_interval_set(struct vty *vty, const char *interval_str, VTY_DECLVAR_CONTEXT(interface, ifp); uint32_t seconds; uint8_t hellomult; - struct in_addr addr; + struct in_addr addr = { INADDR_ANY }; int ret; struct ospf_if_params *params; struct ospf_interface *oi;