[WIP] QPPB | QoS Policy Propagation via BGP (using XDP/BCC/BPF) #12777

1337kerberos · 2023-02-09T09:48:31Z

Draft pull request with the latest draft of QPPB implementation.
The progress and documentation are tracked at VyOS phabricator - T4180

NetDEF-CI · 2023-02-09T09:49:07Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9598/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-PULLREQ2-9598/artifact/CHECKOUT/ErrorLog/log_merge.txt

github-actions · 2023-02-09T10:52:21Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

lib/dscp.c

donaldsharp · 2023-02-10T13:04:49Z

So can you please read workflow.rst and get the commits labeled correctly. Also why does a file need to have vyos in the name? What does the name with vyos provide us ?

NetDEF-CI · 2023-02-19T09:46:57Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Successful on other platforms/tests

FreeBSD 12 amd64 build
Redhat 8 amd64 build
Fedora 29 amd64 build
OpenBSD 7 amd64 build
FreeBSD 11 amd64 build
CentOS 7 amd64 build
Redhat 9 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9781/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Report for bgp_qppb_private.c | 8 issues
===============================================
WARNING: Block comments use a trailing */ on a separate line
#24: FILE: /tmp/f1-1709702/bgp_qppb_private.c:24:
+ * }; */

ERROR: space prohibited before that close parenthesis ')'
#90: FILE: /tmp/f1-1709702/bgp_qppb_private.c:90:
+		 .init = bgp_qppb_module_init, );
Report for bgp_route.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #10852: FILE: /tmp/f1-1709702/bgp_route.c:10852:
Report for bgp_zebra.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #1464: FILE: /tmp/f1-1709702/bgp_zebra.c:1464:
Report for dscp.c | 4 issues
===============================================
ERROR: space required after that close brace '}'
#21: FILE: /tmp/f1-1709702/dscp.c:21:
+	{"voice-admit", DSCP_VOICE}};
Report for routemap_northbound.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #1462: FILE: /tmp/f1-1709702/routemap_northbound.c:1462:
< WARNING: line over 80 characters
< #1463: FILE: /tmp/f1-1709702/routemap_northbound.c:1463:
< WARNING: line over 80 characters
< #1467: FILE: /tmp/f1-1709702/routemap_northbound.c:1467:
Report for xdp_qppb.c | 149 issues
===============================================
ERROR: spaces required around that ':' (ctx:VxW)
#22: FILE: /tmp/f1-1709702/xdp_qppb.c:22:
+#warn XXX: Poor config
          ^

WARNING: C99 // comments do not match recommendation
#54: FILE: /tmp/f1-1709702/xdp_qppb.c:54:
+//               type : key :  leaf : name : size : pin_dir : flags

WARNING: line over 80 characters
#55: FILE: /tmp/f1-1709702/xdp_qppb.c:55:
+BPF_TABLE_PINNED("percpu_array", u32, struct datarec, xdp_stats_map, XDP_ACTION_MAX, STAT_PIN);

WARNING: line over 80 characters
#56: FILE: /tmp/f1-1709702/xdp_qppb.c:56:
+BPF_TABLE_PINNED("lpm_trie", struct lpm_key4, u8, dscp_map, 10240, DSCP_PIN, BPF_F_NO_PREALLOC);

WARNING: line over 80 characters
#57: FILE: /tmp/f1-1709702/xdp_qppb.c:57:
+BPF_TABLE_PINNED("array", u32 /*iface_id*/, u32 /*qppb_bgp_policy*/, qppb_mode_map, 64, QPPB_PIN);

WARNING: C99 // comments do not match recommendation
#58: FILE: /tmp/f1-1709702/xdp_qppb.c:58:
+//               XXX: choose table size limits (read them from sysctl?)

WARNING: Missing a blank line after declarations
#74: FILE: /tmp/f1-1709702/xdp_qppb.c:74:
+	struct datarec *rec = xdp_stats_map.lookup(&action);
+	if (!rec)

ERROR: code indent should use tabs where possible
#85: FILE: /tmp/f1-1709702/xdp_qppb.c:85:
+        __u32 check = bpf_ntohs((__be16)iph->check);$

WARNING: please, no spaces at the start of a line
#85: FILE: /tmp/f1-1709702/xdp_qppb.c:85:
+        __u32 check = bpf_ntohs((__be16)iph->check);$

ERROR: trailing statements should be on next line
#90: FILE: /tmp/f1-1709702/xdp_qppb.c:90:
+	if ((check+1) >> 16) check = (check+1) & 0xffff;

WARNING: Missing a blank line after declarations
#106: FILE: /tmp/f1-1709702/xdp_qppb.c:106:
+	struct meta_info *meta;
+	rc = bpf_xdp_adjust_meta(ctx, -(int)sizeof(*meta));

ERROR: code indent should use tabs where possible
#128: FILE: /tmp/f1-1709702/xdp_qppb.c:128:
+                goto aborted;$

WARNING: please, no spaces at the start of a line
#128: FILE: /tmp/f1-1709702/xdp_qppb.c:128:
+                goto aborted;$

WARNING: line over 80 characters
#137: FILE: /tmp/f1-1709702/xdp_qppb.c:137:
+		bpf_trace_printk("XDP ignore marked packet [%d|%d]", iph->tos, meta->mark);

ERROR: switch and case should be at the same indent
#163: FILE: /tmp/f1-1709702/xdp_qppb.c:163:
+	switch (qppb_mode) {
+		case BGP_POLICY_DST:
[...]
+		case BGP_POLICY_SRC:
[...]
+		default:

WARNING: char * array declaration might be better as static const
#191: FILE: /tmp/f1-1709702/xdp_qppb.c:191:
+	const char *MODES[] = { "MARK_SKB\0", "MARK_META\0", NULL };

WARNING: Missing a blank line after declarations
#192: FILE: /tmp/f1-1709702/xdp_qppb.c:192:
+	const char *MODES[] = { "MARK_SKB\0", "MARK_META\0", NULL };
+	bpf_trace_printk("Mode [%s]\n", MODES[0]

WARNING: space prohibited between function name and open parenthesis '('
#195: FILE: /tmp/f1-1709702/xdp_qppb.c:195:
+	Lookslike bpf version of printk handles only first string arguments (?)

ERROR: spaces required around that '?' (ctx:BxB)
#195: FILE: /tmp/f1-1709702/xdp_qppb.c:195:
+	Lookslike bpf version of printk handles only first string arguments (?)
 	                                                                     ^

WARNING: C99 // comments do not match recommendation
#197: FILE: /tmp/f1-1709702/xdp_qppb.c:197:
+		https://nakryiko.com/posts/bpf-tips-printk/

ERROR: spaces required around that ':' (ctx:VxE)
#197: FILE: /tmp/f1-1709702/xdp_qppb.c:197:
+		https://nakryiko.com/posts/bpf-tips-printk/
 		     ^

ERROR: spaces required around that ':' (ctx:VxW)
#200: FILE: /tmp/f1-1709702/xdp_qppb.c:200:
+out:     return xdp_stats_record_action(ctx, action);
    ^

WARNING: C99 // comments do not match recommendation
#202: FILE: /tmp/f1-1709702/xdp_qppb.c:202:
+aborted: return xdp_stats_record_action(ctx, XDP_ABORTED);  // packet is dropped

ERROR: spaces required around that ':' (ctx:VxW)
#203: FILE: /tmp/f1-1709702/xdp_qppb.c:203:
+skip:    return action;
     ^

WARNING: C99 // comments do not match recommendation
#212: FILE: /tmp/f1-1709702/xdp_qppb.c:212:
+	// Default priority

WARNING: C99 // comments do not match recommendation
#214: FILE: /tmp/f1-1709702/xdp_qppb.c:214:
+	// Check XDP gave us some data_meta

ERROR: "(foo*)" should be "(foo *)"
#215: FILE: /tmp/f1-1709702/xdp_qppb.c:215:
+	if ((void*)(meta + 1) > data)

ERROR: switch and case should be at the same indent
#222: FILE: /tmp/f1-1709702/xdp_qppb.c:222:
+	switch(meta->mark >> 2) {
+		case 10: skb->tc_classid = 0x10; break;
+		case 20: skb->tc_classid = 0x20; break;
+		case 30: skb->tc_classid = 0x30; break;
+		case 40: skb->tc_classid = 0x40; break;

ERROR: space required before the open parenthesis '('
#222: FILE: /tmp/f1-1709702/xdp_qppb.c:222:
+	switch(meta->mark >> 2) {

ERROR: trailing statements should be on next line
#223: FILE: /tmp/f1-1709702/xdp_qppb.c:223:
+		case 10: skb->tc_classid = 0x10; break;

ERROR: trailing statements should be on next line
#224: FILE: /tmp/f1-1709702/xdp_qppb.c:224:
+		case 20: skb->tc_classid = 0x20; break;

ERROR: trailing statements should be on next line
#225: FILE: /tmp/f1-1709702/xdp_qppb.c:225:
+		case 30: skb->tc_classid = 0x30; break;

ERROR: trailing statements should be on next line
#226: FILE: /tmp/f1-1709702/xdp_qppb.c:226:
+		case 40: skb->tc_classid = 0x40; break;

NetDEF-CI · 2023-02-19T10:37:41Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9782/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: No useful log found

Successful on other platforms/tests

FreeBSD 12 amd64 build
OpenBSD 7 amd64 build
Redhat 8 amd64 build
Fedora 29 amd64 build
FreeBSD 11 amd64 build
CentOS 7 amd64 build
Redhat 9 amd64 build

NetDEF-CI · 2023-02-19T10:50:25Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Successful on other platforms/tests

FreeBSD 12 amd64 build
Fedora 29 amd64 build
OpenBSD 7 amd64 build
Redhat 8 amd64 build
CentOS 7 amd64 build
FreeBSD 11 amd64 build
Redhat 9 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 i386 build: Failed (click for details)

Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/ErrorLog/ Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/config.status/config.status Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18I386BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 i386 build: No useful log found

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/config.log/config.log.gz Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/ErrorLog/ Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/config.status/config.status Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB11AMD64/frr.xref.xz/frr.xref.xz Debian 11 amd64 build: No useful log found

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/config.log/config.log.gz Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM7BUILD/ErrorLog/ Ubuntu 18.04 arm7 build: No useful log found

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/ErrorLog/ Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/config.log/config.log.gz Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: No useful log found

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/frr.xref.xz/frr.xref.xz Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/config.status/config.status Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/ErrorLog/ Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/DEB10BUILD/config.log/config.log.gz Debian 10 amd64 build: No useful log found

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/ErrorLog/ Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/config.log/config.log.gz Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: No useful log found

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/config.log/config.log.gz Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/ErrorLog/ Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U22AMD64BUILD/config.status/config.status Ubuntu 22.04 amd64 build: No useful log found

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/frr.xref.xz/frr.xref.xz Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/config.status/config.status Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI021BUILD/ErrorLog/ Debian 9 amd64 build: No useful log found

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/frr.xref.xz/frr.xref.xz Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/config.status/config.status Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804AMD64/ErrorLog/ Ubuntu 18.04 amd64 build: No useful log found

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/config.log/config.log.gz Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U16ARM8BUILD/ErrorLog/ Ubuntu 16.04 arm8 build: No useful log found

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/frr.xref.xz/frr.xref.xz Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/CI014BUILD/ErrorLog/ Ubuntu 16.04 amd64 build: No useful log found

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U1804PPC64LEBUILD/ErrorLog/ Ubuntu 18.04 ppc64le build: No useful log found

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/frr.xref.xz/frr.xref.xz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/config.log/config.log.gz Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/ErrorLog/ Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9783/artifact/U2004AMD64BUILD/config.status/config.status Ubuntu 20.04 amd64 build: No useful log found

Report for bgp_qppb_private.c | 8 issues
===============================================
WARNING: Block comments use a trailing */ on a separate line
#24: FILE: /tmp/f1-1958723/bgp_qppb_private.c:24:
+ * }; */

ERROR: space prohibited before that close parenthesis ')'
#90: FILE: /tmp/f1-1958723/bgp_qppb_private.c:90:
+		 .init = bgp_qppb_module_init, );
Report for bgp_route.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #10852: FILE: /tmp/f1-1958723/bgp_route.c:10852:
Report for bgp_zebra.c | 2 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #1464: FILE: /tmp/f1-1958723/bgp_zebra.c:1464:
Report for dscp.c | 4 issues
===============================================
ERROR: space required after that close brace '}'
#21: FILE: /tmp/f1-1958723/dscp.c:21:
+	{"voice-admit", DSCP_VOICE}};
Report for routemap_northbound.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #1462: FILE: /tmp/f1-1958723/routemap_northbound.c:1462:
< WARNING: line over 80 characters
< #1463: FILE: /tmp/f1-1958723/routemap_northbound.c:1463:
< WARNING: line over 80 characters
< #1467: FILE: /tmp/f1-1958723/routemap_northbound.c:1467:
Report for xdp_qppb.c | 149 issues
===============================================
ERROR: spaces required around that ':' (ctx:VxW)
#22: FILE: /tmp/f1-1958723/xdp_qppb.c:22:
+#warn XXX: Poor config
          ^

WARNING: C99 // comments do not match recommendation
#54: FILE: /tmp/f1-1958723/xdp_qppb.c:54:
+//               type : key :  leaf : name : size : pin_dir : flags

WARNING: line over 80 characters
#55: FILE: /tmp/f1-1958723/xdp_qppb.c:55:
+BPF_TABLE_PINNED("percpu_array", u32, struct datarec, xdp_stats_map, XDP_ACTION_MAX, STAT_PIN);

WARNING: line over 80 characters
#56: FILE: /tmp/f1-1958723/xdp_qppb.c:56:
+BPF_TABLE_PINNED("lpm_trie", struct lpm_key4, u8, dscp_map, 10240, DSCP_PIN, BPF_F_NO_PREALLOC);

WARNING: line over 80 characters
#57: FILE: /tmp/f1-1958723/xdp_qppb.c:57:
+BPF_TABLE_PINNED("array", u32 /*iface_id*/, u32 /*qppb_bgp_policy*/, qppb_mode_map, 64, QPPB_PIN);

WARNING: C99 // comments do not match recommendation
#58: FILE: /tmp/f1-1958723/xdp_qppb.c:58:
+//               XXX: choose table size limits (read them from sysctl?)

WARNING: Missing a blank line after declarations
#74: FILE: /tmp/f1-1958723/xdp_qppb.c:74:
+	struct datarec *rec = xdp_stats_map.lookup(&action);
+	if (!rec)

ERROR: code indent should use tabs where possible
#85: FILE: /tmp/f1-1958723/xdp_qppb.c:85:
+        __u32 check = bpf_ntohs((__be16)iph->check);$

WARNING: please, no spaces at the start of a line
#85: FILE: /tmp/f1-1958723/xdp_qppb.c:85:
+        __u32 check = bpf_ntohs((__be16)iph->check);$

ERROR: trailing statements should be on next line
#90: FILE: /tmp/f1-1958723/xdp_qppb.c:90:
+	if ((check+1) >> 16) check = (check+1) & 0xffff;

WARNING: Missing a blank line after declarations
#106: FILE: /tmp/f1-1958723/xdp_qppb.c:106:
+	struct meta_info *meta;
+	rc = bpf_xdp_adjust_meta(ctx, -(int)sizeof(*meta));

ERROR: code indent should use tabs where possible
#128: FILE: /tmp/f1-1958723/xdp_qppb.c:128:
+                goto aborted;$

WARNING: please, no spaces at the start of a line
#128: FILE: /tmp/f1-1958723/xdp_qppb.c:128:
+                goto aborted;$

WARNING: line over 80 characters
#137: FILE: /tmp/f1-1958723/xdp_qppb.c:137:
+		bpf_trace_printk("XDP ignore marked packet [%d|%d]", iph->tos, meta->mark);

ERROR: switch and case should be at the same indent
#163: FILE: /tmp/f1-1958723/xdp_qppb.c:163:
+	switch (qppb_mode) {
+		case BGP_POLICY_DST:
[...]
+		case BGP_POLICY_SRC:
[...]
+		default:

WARNING: char * array declaration might be better as static const
#191: FILE: /tmp/f1-1958723/xdp_qppb.c:191:
+	const char *MODES[] = { "MARK_SKB\0", "MARK_META\0", NULL };

WARNING: Missing a blank line after declarations
#192: FILE: /tmp/f1-1958723/xdp_qppb.c:192:
+	const char *MODES[] = { "MARK_SKB\0", "MARK_META\0", NULL };
+	bpf_trace_printk("Mode [%s]\n", MODES[0]

WARNING: space prohibited between function name and open parenthesis '('
#195: FILE: /tmp/f1-1958723/xdp_qppb.c:195:
+	Lookslike bpf version of printk handles only first string arguments (?)

ERROR: spaces required around that '?' (ctx:BxB)
#195: FILE: /tmp/f1-1958723/xdp_qppb.c:195:
+	Lookslike bpf version of printk handles only first string arguments (?)
 	                                                                     ^

WARNING: C99 // comments do not match recommendation
#197: FILE: /tmp/f1-1958723/xdp_qppb.c:197:
+		https://nakryiko.com/posts/bpf-tips-printk/

ERROR: spaces required around that ':' (ctx:VxE)
#197: FILE: /tmp/f1-1958723/xdp_qppb.c:197:
+		https://nakryiko.com/posts/bpf-tips-printk/
 		     ^

ERROR: spaces required around that ':' (ctx:VxW)
#200: FILE: /tmp/f1-1958723/xdp_qppb.c:200:
+out:     return xdp_stats_record_action(ctx, action);
    ^

WARNING: C99 // comments do not match recommendation
#202: FILE: /tmp/f1-1958723/xdp_qppb.c:202:
+aborted: return xdp_stats_record_action(ctx, XDP_ABORTED);  // packet is dropped

ERROR: spaces required around that ':' (ctx:VxW)
#203: FILE: /tmp/f1-1958723/xdp_qppb.c:203:
+skip:    return action;
     ^

WARNING: C99 // comments do not match recommendation
#212: FILE: /tmp/f1-1958723/xdp_qppb.c:212:
+	// Default priority

WARNING: C99 // comments do not match recommendation
#214: FILE: /tmp/f1-1958723/xdp_qppb.c:214:
+	// Check XDP gave us some data_meta

ERROR: "(foo*)" should be "(foo *)"
#215: FILE: /tmp/f1-1958723/xdp_qppb.c:215:
+	if ((void*)(meta + 1) > data)

ERROR: switch and case should be at the same indent
#222: FILE: /tmp/f1-1958723/xdp_qppb.c:222:
+	switch(meta->mark >> 2) {
+		case 10: skb->tc_classid = 0x10; break;
+		case 20: skb->tc_classid = 0x20; break;
+		case 30: skb->tc_classid = 0x30; break;
+		case 40: skb->tc_classid = 0x40; break;

ERROR: space required before the open parenthesis '('
#222: FILE: /tmp/f1-1958723/xdp_qppb.c:222:
+	switch(meta->mark >> 2) {

ERROR: trailing statements should be on next line
#223: FILE: /tmp/f1-1958723/xdp_qppb.c:223:
+		case 10: skb->tc_classid = 0x10; break;

ERROR: trailing statements should be on next line
#224: FILE: /tmp/f1-1958723/xdp_qppb.c:224:
+		case 20: skb->tc_classid = 0x20; break;

ERROR: trailing statements should be on next line
#225: FILE: /tmp/f1-1958723/xdp_qppb.c:225:
+		case 30: skb->tc_classid = 0x30; break;

ERROR: trailing statements should be on next line
#226: FILE: /tmp/f1-1958723/xdp_qppb.c:226:
+		case 40: skb->tc_classid = 0x40; break;

github-actions · 2023-03-22T17:45:49Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-09-19T01:44:18Z

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

1337kerberos · 2023-10-01T16:59:09Z

Still WIP, don't close

github-actions · 2024-01-30T15:58:42Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1337kerberos · 2024-03-18T15:29:53Z

Hi all! Sorry for taking so long with this feature. My team is looking forward to this getting merged.
@riw777, @donaldsharp could you dedicate some time to reviewing my changes? Thank you in advance!)
As well, I have prepared a GNS demo and will share the link over Slack.

Regarding the patch set size:

- Commit `bgpd, zebra, tests: move plugin down to zebra` is a separate commit for now.
I have made this change on @donaldsharp's request from the dev meeting.
The plan is to squash it across the relevant commits after the review.

- The last commit `tests: implement dscp -> vrf packet switching demo` is there to display what I had progressed on.
Once the feature is approved, I will drop it from this patch set and upload it separately.

github-actions · 2024-03-26T14:05:53Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

mjstapp

This PR offers changes in several areas; I have some reservations about some of those changes. At a high level, what is being proposed is to add a new dscp field or attribute to the FRR routemap. BGP is then extended to store that routemap attribute, and the route zapi message and zebra are similarly extended so that that new value can be conveyed from BGP to zebra. Whether or not that seems like a reasonable thing to want to do, most of the PR is in other areas. It proposes adding an XDP/kernel module - isn't that what that is? It proposes making some meaningful changes to the topotest infrastructure, and adding some very OS-specific test code.

So first questions: why BGP? as a protocol, BGP isn't involved at all: it's just a host for a routemap - isn't that right? Why not ... run the routemap in zebra, for example? Adding BGP in this way introduces some issues (IMO) like: there's a BGP cli that shows this new dscp value, but no zebra show output? It seems pretty fragile to be unable to see what zebra is doing in an area like this.

On the zebra side, it appears that a synchronous call is made through a new hook callout that will make BPF calls in the zebra main pthread context. For me, that's kind of a non-starter: we've worked hard to remove dataplane work from the main pthread, and I don't think we should start backtracking now.

We already have in FRR several qos-oriented features. We have the existing PBR daemon, which is somewhat focussed on a certain pattern of use, but which might be a candidate to convey per-prefix qos information. We also have some initial, partial TC support that's closely (probably too closely) based on linux TC. It would be great to see that initial work improved and extended to become more useful.

Similarly, we have a plugin-based dataplane subsystem in zebra that is intended to offload OS-specific communication. I'd prefer to see how that layer could be used or extended to support new dataplane features.

pguibert6WIND · 2024-03-27T20:54:34Z

So first questions: why BGP?

I tend do think that QPPB is already supported by other customers.
https://www.noction.com/blog/qos-policy-propagation-via-bgp-qppb

mjstapp · 2024-03-28T12:04:36Z

In this proposal, the BGP protocol is not involved at all - BGP just acts as the host for a routemap.

To me, this feels like an ... experiment, a demo, a proof-of-concept - and that's fine, that's up to vyos. But it may not be a good proposal for FRR.

So first questions: why BGP?

I tend do think that QPPB is already supported by other customers. https://www.noction.com/blog/qos-policy-propagation-via-bgp-qppb

Pull out all DSCP related code from PBR into a separate library module. Relevant for route-maps used by the QPPB plugin. Signed-off-by: Volodymyr Huti <[email protected]>

Signed-off-by: Volodymyr Huti <[email protected]>

Check the documentation for more details: https://phabricator.vyos.net/T4180 Signed-off-by: Volodymyr Huti <[email protected]>

Convert the iperf/tcpdump helper functions into HostApplicationHelper interface. Signed-off-by: Volodymyr Huti <[email protected]>

Check the documentation for more details: https://phabricator.vyos.net/T4180 Signed-off-by: Volodymyr Huti <[email protected]>

Move plugin invocation lower in the demon stack. This way, dscp tag is exposed for usage to the rest of demons. Signed-off-by: Volodymyr Huti <[email protected]>

1337kerberos · 2024-04-03T22:56:24Z

It proposes adding an XDP/kernel module - isn't that what that is? It proposes
making some meaningful changes to the topotest infrastructure, and adding some
very OS-specific test code.

This PR includes:

plugin to access bpf mappings
XDP hooks (200 line C files) compiled/attached by bcc/tc
extension of bgp_attr/route map struct
reference Cisco topology + QOS setup in topotest
a functional test for the XDP hooks (modifying bpf mappings, the OS-specific test code)
This PR shows how to interact with BPF and XDP from the FRR routing stack.

Why not ... run the routemap in zebra, for example?
BGP cli that shows this new dscp value, but no zebra show output?
In this proposal, the BGP protocol is not involved at all - BGP just acts as
the host for a routemap.

So the first intuition is that QPPB is QoS over BGP. I have looked into the bgpd.
Although I understand what you are talking about, I can move the routemap
logic + cli show cmd down to zebra. Is this a reasonable change?

On the zebra side, it appears that a synchronous call is made

This hook performs a write operation in the bpf map (LPM [prefix, dscp]) using bpf_map_update_elem api.
If that is your concern, I expect no serious performance overhead for this operation.

Similarly, we have a plugin-based dataplane subsystem in zebra that is intended
to offload OS-specific communication. I'd prefer to see how that layer could be
used or extended to support new dataplane features.

What would be a better place to call my plugin from data plane subsystem?
I'm going to research this, and advice would be helpful)

To me, this feels like an ... experiment, a demo, a proof-of-concept - and
that's fine, that's up to vyos.

Sure, that is no problem. But would it be possible to define a minimal list of changes
that you would like for this feature to become applicable for FRR.
I would be glad to fix things up. I have also prepared a demo, which I am going to share over Slack.

github-actions · 2024-05-13T14:01:56Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1337kerberos · 2024-08-28T22:59:58Z

Hi all, I am moving this to draft, assuming there will be interest in the future
Current state - rebased 5 out of 6 patches. The last has an issue -
ADD/DEL bgp route logic was divided, so I don't have dscp on DEL
I`m going to approach maintainers one more time if they see any potential

github-actions bot added master size/XXL labels Feb 9, 2023

github-actions bot added the conflicts label Feb 9, 2023

donaldsharp reviewed Feb 10, 2023

View reviewed changes

lib/dscp.c Outdated Show resolved Hide resolved

riw777 self-requested a review February 14, 2023 14:28

1337kerberos force-pushed the QPPB_DEMO_V2 branch from 135da45 to 63c1612 Compare February 19, 2023 09:23

frrbot bot added bgp libfrr pbr tests Topotests, make check, etc yang labels Feb 19, 2023

github-actions bot removed the conflicts label Feb 19, 2023

1337kerberos changed the title ~~QPPB | QoS Policy Propagation via BGP (using XDP/BCC/BPF)~~ [WIP] QPPB | QoS Policy Propagation via BGP (using XDP/BCC/BPF) Feb 19, 2023

1337kerberos force-pushed the QPPB_DEMO_V2 branch from 63c1612 to 01acef1 Compare February 19, 2023 10:05

frrbot bot added the bugfix label Feb 19, 2023

1337kerberos force-pushed the QPPB_DEMO_V2 branch from 01acef1 to d851be8 Compare February 19, 2023 10:16

github-actions bot added the conflicts label Mar 22, 2023

github-actions bot added the autoclose label Sep 19, 2023

github-actions bot removed the autoclose label Oct 2, 2023

1337kerberos force-pushed the QPPB_DEMO_V2 branch from d851be8 to e247740 Compare October 4, 2023 16:13

github-actions bot removed the conflicts label Oct 4, 2023

1337kerberos force-pushed the QPPB_DEMO_V2 branch from c205b25 to 943e69f Compare February 24, 2024 20:45

github-actions bot removed the conflicts label Feb 24, 2024

1337kerberos force-pushed the QPPB_DEMO_V2 branch 3 times, most recently from 79321ff to a7227b7 Compare March 15, 2024 13:53

1337kerberos force-pushed the QPPB_DEMO_V2 branch 5 times, most recently from dd9acd7 to 96df386 Compare March 19, 2024 16:51

github-actions bot added the conflicts label Mar 26, 2024

mjstapp reviewed Mar 27, 2024

View reviewed changes

Volodymyr Huti and others added 6 commits April 1, 2024 12:40

lib, pbrd: Move DSCP logic into a library module

d8fa3d5

Pull out all DSCP related code from PBR into a separate library module. Relevant for route-maps used by the QPPB plugin. Signed-off-by: Volodymyr Huti <[email protected]>

bgp, lib, yang: Extend route-map to support the DSCP tag

2bb38d2

Signed-off-by: Volodymyr Huti <[email protected]>

bgpd: Initial QPPB plugin for interacting with BPF mappings

6122f66

Check the documentation for more details: https://phabricator.vyos.net/T4180 Signed-off-by: Volodymyr Huti <[email protected]>

tests: Rework IPerf/Tcpdump host helpers

c42708e

Convert the iperf/tcpdump helper functions into HostApplicationHelper interface. Signed-off-by: Volodymyr Huti <[email protected]>

tests: Implement test suit with common setups, based on BCC

23c3a4d

Check the documentation for more details: https://phabricator.vyos.net/T4180 Signed-off-by: Volodymyr Huti <[email protected]>

bgpd, zebra, tests: move plugin down to zebra

1f18c93

Move plugin invocation lower in the demon stack. This way, dscp tag is exposed for usage to the rest of demons. Signed-off-by: Volodymyr Huti <[email protected]>

1337kerberos force-pushed the QPPB_DEMO_V2 branch from 96df386 to 1f18c93 Compare April 1, 2024 09:59

github-actions bot removed the conflicts label Apr 1, 2024

github-actions bot added the conflicts label May 13, 2024

1337kerberos marked this pull request as draft August 28, 2024 22:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] QPPB | QoS Policy Propagation via BGP (using XDP/BCC/BPF) #12777

[WIP] QPPB | QoS Policy Propagation via BGP (using XDP/BCC/BPF) #12777

1337kerberos commented Feb 9, 2023

NetDEF-CI commented Feb 9, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Failed

github-actions bot commented Feb 9, 2023

donaldsharp commented Feb 10, 2023

NetDEF-CI commented Feb 19, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Feb 19, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Feb 19, 2023

github-actions bot commented Mar 22, 2023

github-actions bot commented Sep 19, 2023

1337kerberos commented Oct 1, 2023

github-actions bot commented Jan 30, 2024

1337kerberos commented Mar 18, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024

mjstapp left a comment

pguibert6WIND commented Mar 27, 2024

mjstapp commented Mar 28, 2024

1337kerberos commented Apr 3, 2024 •

edited

Loading

github-actions bot commented May 13, 2024

1337kerberos commented Aug 28, 2024

[WIP] QPPB | QoS Policy Propagation via BGP (using XDP/BCC/BPF) #12777

Are you sure you want to change the base?

[WIP] QPPB | QoS Policy Propagation via BGP (using XDP/BCC/BPF) #12777

Conversation

1337kerberos commented Feb 9, 2023

NetDEF-CI commented Feb 9, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Failed

github-actions bot commented Feb 9, 2023

donaldsharp commented Feb 10, 2023

NetDEF-CI commented Feb 19, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Feb 19, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Feb 19, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

github-actions bot commented Mar 22, 2023

github-actions bot commented Sep 19, 2023

1337kerberos commented Oct 1, 2023

github-actions bot commented Jan 30, 2024

1337kerberos commented Mar 18, 2024 • edited Loading

github-actions bot commented Mar 26, 2024

mjstapp left a comment

Choose a reason for hiding this comment

pguibert6WIND commented Mar 27, 2024

mjstapp commented Mar 28, 2024

1337kerberos commented Apr 3, 2024 • edited Loading

github-actions bot commented May 13, 2024

1337kerberos commented Aug 28, 2024

NetDEF-CI commented Feb 9, 2023 •

edited

Loading

NetDEF-CI commented Feb 19, 2023 •

edited

Loading

NetDEF-CI commented Feb 19, 2023 •

edited

Loading

1337kerberos commented Mar 18, 2024 •

edited

Loading

1337kerberos commented Apr 3, 2024 •

edited

Loading