bgpd: fix withdraw stale routes #13647
Conversation
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11878/ This is a comment from an automated CI system. |
|
Topotest? |
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
d581830 to
14ce246
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-11998/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 Topotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-11998/test Topology Tests failed for Topotests debian 10 amd64 part 9 Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-11998/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11998/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-11998/test Topology Tests failed for Topotests debian 10 amd64 part 6 Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-11998/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 Addresssanitizer topotests part 4: Incomplete(check logs for details)Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-12000/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7 Topotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12000/test Topology Tests failed for Topotests debian 10 amd64 part 9 Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12000/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Successful on other platforms/tests
|
|
ci:rerun |
just added |
There was a problem hiding this comment.
Hm, I tried running this PR locally, and it fails all the time for me :/
2023-06-05 22:04:24,186 ERROR: topolog: 'check_show_bgp_ipv4_prefix' failed after 41.02 seconds
---------------------------------------------------------------------- generated xml file: /tmp/topotests/topotests.xml -----------------------------------------------------------------------
=================================================================================== short test summary info ===================================================================================
FAILED test_bgp_vpnv4_gr.py::test_cut_link - AssertionError: "r1" JSON output mismatches
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12011/test Topology Tests failed for Topotests debian 10 amd64 part 9 Topotests debian 10 amd64 part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12011/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Successful on other platforms/tests
|
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
14ce246 to
b75a87a
Compare
I tried with upstream, and even with 'pip3 install pytest-asyncio', and it works for me. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-12029/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12029/artifact/TP3U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-12029/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3 Successful on other platforms/tests
|
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
b75a87a to
78748f4
Compare
|
@Mergifyio backport dev/9.0 stable/8.4 stable/8.5 |
🟠 Waiting for conditions to match
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 3: Failed (click for details)Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12043/artifact/TOPO3U18I386/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12043/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3 Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12043/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundSuccessful on other platforms/tests
|
|
Seems a valid failure yet: |
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
78748f4 to
9ab40f4
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12086/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12086/artifact/TP3U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-12086/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3 Successful on other platforms/tests
|
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
9ab40f4 to
bb8df02
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12311/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundSuccessful on other platforms/tests
|
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
2 times, most recently
from
65dfee2 to
18f100b
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12401/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12401/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundSuccessful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-12402/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-12402/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12402/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-12402/test Topology Tests failed for Topotests debian 10 amd64 part 6 Successful on other platforms/tests
|
|
Seems valid failures yet. |
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
18f100b to
f6ba066
Compare
Continuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-13868/test Topology Tests failed for Topotests debian 10 amd64 part 6 Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13868/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-13868/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 Addresssanitizer topotests part 4: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-13868/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 Successful on other platforms/tests
|
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
f6ba066 to
4665bd4
Compare
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
2 times, most recently
from
dadb25c to
cfd7a5d
Compare
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
cfd7a5d to
c62d315
Compare
This test creates a BGP peering with 2 VPNv4 routes that became staled after the link between the peering becomes down. - One test checks that the routes are removed on the BGP listener. Then the recovery re-adds the routes. - The other test removes one of the two received routes, after the link is down. Then a recovery happens. The expectation is that the removed route is removed from the BGP listener, while the maintained route is kept. Link: FRRouting#13647 Signed-off-by: Philippe Guibert <[email protected]> Signed-off-by: Louis Scalbert <[email protected]>
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
c62d315 to
03219ce
Compare
| # SPDX-License-Identifier: ISC | ||
| from ansible_collections.community.aws.plugins.modules.aws_direct_connect_virtual_interface import ( | ||
| exact_match, | ||
| ) |
There was a problem hiding this comment.
please remove this import
Incoming MPLS VPN staled routes are not flushing imported entries, upon expiration of the stalepath timer. The incoming MPLS VPN staled routes that are received from a given peer have a sub_type set to BGP_ROUTE_NORMAL. The original patch is wrong as it filters out the locally exported routes marked with the BGP_ROUTE_IMPORTED subtype. Fix this by extending the test to all MPLS VPN routes received from this peer. Fixes: 641065d ("bgpd: VRF-Lite fix to clear stale leaked routes") Signed-off-by: Philippe Guibert <[email protected]>
This test creates a BGP peering with 2 VPNv4 routes that became staled after the link between the peering becomes down. - One test checks that the routes are removed on the BGP listener. Then the recovery re-adds the routes. - The other test removes one of the two received routes, after the link is down. Then a recovery happens. The expectation is that the removed route is removed from the BGP listener, while the maintained route is kept. Link: FRRouting#13647 Signed-off-by: Philippe Guibert <[email protected]> Signed-off-by: Louis Scalbert <[email protected]>
pguibert6WIND
force-pushed
the
stale_routes_cc
branch
from
03219ce to
e83efcd
Compare
Incoming MPLS VPN staled routes are not flushing imported entries, upon expiration of the stalepath timer.
The incoming MPLS VPN staled routes that are received from a given peer have a sub_type set to BGP_ROUTE_NORMAL. The original patch is wrong as it filters out the locally exported routes marked with the BGP_ROUTE_IMPORTED subtype.
Fix this by extending the test to all MPLS VPN routes received from this peer.
Fixes: 641065d ("bgpd: VRF-Lite fix to clear stale leaked routes")